Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove emails from AUTHORS.txt #5979

Closed
pradyunsg opened this issue Nov 2, 2018 · 8 comments · Fixed by #7899
Closed

Remove emails from AUTHORS.txt #5979

pradyunsg opened this issue Nov 2, 2018 · 8 comments · Fixed by #7899
Labels
auto-locked state: awaiting PR type: maintenance

Comments

@pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Nov 2, 2018

This came up in #4891.

Currently, that file can be used to farm emails for spamming. It can still be done with the git repository but it's an step more to get them compared to a text file.

Filing this for discussion.

@pradyunsg pradyunsg added the state: needs discussion label Nov 2, 2018
@dstufft
Copy link
Member

@dstufft dstufft commented Nov 2, 2018

I think it's fine to do so. The original AUTHORS file didn't have emails in them, I switched it to have emails at some point (#1594), though I don't really remember why I did.

@xanderyzwich
Copy link

@xanderyzwich xanderyzwich commented Dec 19, 2018

pull request submitted

@hugovk
Copy link
Contributor

@hugovk hugovk commented Feb 18, 2019

Link to PR: #6046 (currently needs rebase)

@chrahunt chrahunt added state: awaiting PR type: maintenance and removed state: needs discussion labels Oct 6, 2019
@deveshks
Copy link
Contributor

@deveshks deveshks commented Mar 25, 2020

Hi @pradyunsg

Can I file a new PR for this? Seems like an old PR was filed #6046 but was never merged. I can take the changes for it and create a new one, if there is still scope to fix it?

@uranusjr
Copy link
Member

@uranusjr uranusjr commented Mar 25, 2020

@deveshks Go head 👍

@deveshks
Copy link
Contributor

@deveshks deveshks commented Mar 25, 2020

Hi @uranusjr ,

Thank you. I will submit a PR for this. Another question, is there a place in one of the .rst files where I can put a guideline on how to update AUTHORS.txt, and document that only names should be added in AUTHORS.txt in future

@uranusjr
Copy link
Member

@uranusjr uranusjr commented Mar 25, 2020

@deveshks The file is generated automatically when releasing a new version, implementated (you can trace it from function prepare_release() in noxfile.py). I think the best way to do this would be to change the generation logic, and just run it to re-generate the file.

@deveshks
Copy link
Contributor

@deveshks deveshks commented Mar 25, 2020

Hi @uranusjr

Thanks for the suggestions. I have updated the format for git log command as well in noxfile.py, thanks to @pradyunsg who mentioned about it when I asked a question on the IRC channel, and created a PR

@lock lock bot added the auto-locked label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked state: awaiting PR type: maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants