Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
pip-19.x: `pip wheel` does not pick a whl on PEP-517 project #6196
How to Reproduce
a similar case is reproduced in
Hi @gjo! Thanks for filing this!
$ python3 -m venv /tmp/pip-6196-tester $ cd /tmp/pip-6196-tester $ bin/pip install -U pip $ mkpkg trial $ touch trial/pyproject.toml $ cd trial $ python setup.py sdist $ ../bin/pip wheel -f wheelhouse -w wheelhouse . Looking in links: wheelhouse Processing /private/tmp/pip-6196-tester/trial Installing build dependencies ... done Getting requirements to build wheel ... done Preparing wheel metadata ... done Building wheels for collected packages: trial Building wheel for trial (PEP 517) ... done Stored in directory: /private/tmp/pip-6196-tester/trial/wheelhouse Successfully built trial $ tree wheelhouse wheelhouse └── trial-0.1.0.tar.gz 0 directories, 1 file
So... I can reproduce this issue! Thanks for a detailed report! :)
The install case seems to be working fine for me. I tried this locally:
$ python3 -m venv /tmp/pip-6196-tester $ cd /tmp/pip-6196-tester $ bin/pip install -U pip --quiet $ mkpkg trial # https://github.com/pradyunsg/dotfiles/blob/master/src/python/aliases.zsh $ touch trial/pyproject.toml $ tree trial trial ├── setup.py ├── pyproject.toml └── trial └── __init__.py 1 directory, 3 files $ bin/pip install ./trial Processing ./trial Installing build dependencies ... done Getting requirements to build wheel ... done Preparing wheel metadata ... done Building wheels for collected packages: trial Building wheel for trial (PEP 517) ... done Stored in directory: /private/var/folders/4d/bt0_xfx56bjfmmt2bv3r5_qh0000gn/T/pip-ephem-wheel-cache-qo7imeut/wheels/d9/26/8a/63a8ca08ceb31ad86bf93bd6f9913bf64a86363730b6359887 Successfully built trial Installing collected packages: trial Successfully installed trial-0.1.0
And... I have trouble reproducing this in the test suite. Turns out
My latest attempt at writing the test
def test_pep517_wheels_are_not_confused_with_other_files(script, tmpdir, data): """Check correct wheels are copied. (#6196) """ pkg_to_wheel = data.src / 'withpyproject' (pkg_to_wheel / 'dist').makedirs() (pkg_to_wheel / 'dist' / 'withpyproject-0.0.1.tar.gz').write("hello") result = script.pip('wheel', pkg_to_wheel, '-w', script.scratch_path) assert "Installing build dependencies" in result.stdout, result.stdout wheel_file_name = 'withpyproject-0.0.1-py%s-none-any.whl' % pyversion wheel_file_path = script.scratch_path / wheel_file_name assert wheel_file_path in result.files_created, result.stdout
referenced this issue
Feb 3, 2019
Thank you @pradyunsg !