Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for yanked files from a repository (PEP 592) #6633

Closed
brainwane opened this issue Jun 22, 2019 · 2 comments · Fixed by #6647
Closed

Add support for yanked files from a repository (PEP 592) #6633

brainwane opened this issue Jun 22, 2019 · 2 comments · Fixed by #6647
Labels
auto-locked Outdated issues that have been locked by automation C: dependency resolution About choosing which dependencies to install C: download About fetching data from PyPI and other sources help wanted For requesting inputs from other members of the community PEP implementation Involves some PEP type: feature request Request for a new feature

Comments

@brainwane
Copy link
Member

What's the problem this feature will solve?
To quote PEP 592:

This PEP proposes adding the ability to mark a particular file download on a simple repository as "yanked". Yanking a file allows authors to effectively delete a file, without breaking things for people who have pinned to exactly a specific version.

Describe the solution you'd like
Have pip respect yanking in the PyPI/Warehouse API.

Additional context

Support for PEP 592 -- Adding "Yank" Support to the Simple API will affect which packages get chosen. This will therefore affect the pip resolver, but does not have to wait for the new resolver rewrite (#988 @pradyunsg).

@dstufft is currently working on the PyPI side in pypi/warehouse#5838 . There's an opportunity for someone to help by working on pip support; not sure whether Donald's working on it and/or whether this feature is blocked on the Warehouse API getting into better shape.

@triage-new-issues triage-new-issues bot added the S: needs triage Issues/PRs that need to be triaged label Jun 22, 2019
@brainwane brainwane added C: dependency resolution About choosing which dependencies to install C: download About fetching data from PyPI and other sources help wanted For requesting inputs from other members of the community PEP implementation Involves some PEP type: feature request Request for a new feature labels Jun 22, 2019
@triage-new-issues triage-new-issues bot removed S: needs triage Issues/PRs that need to be triaged labels Jun 22, 2019
@cjerdonek
Copy link
Member

I think it might be better to title this "Support yank ..." or "Add support for yanking ...." Currently, it reads like it's to stop supporting pip in some setting (at least that's how I read it, and didn't know it was about the "yank" feature until clicking through).

@brainwane brainwane changed the title Yank support for pip (PEP 592) Support/respect PEP 592 (yanking a file on a repository) Jun 22, 2019
@pradyunsg pradyunsg changed the title Support/respect PEP 592 (yanking a file on a repository) Add support for yanked files from a repository (PEP 592) Jun 22, 2019
@cjerdonek
Copy link
Member

I posted PR #6647 for this.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jul 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: dependency resolution About choosing which dependencies to install C: download About fetching data from PyPI and other sources help wanted For requesting inputs from other members of the community PEP implementation Involves some PEP type: feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants