Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pip shows password in index-url in the "Downloading <url>" message #6783

Closed
pradyunsg opened this issue Jul 24, 2019 · 7 comments · Fixed by #7373
Closed

pip shows password in index-url in the "Downloading <url>" message #6783

pradyunsg opened this issue Jul 24, 2019 · 7 comments · Fixed by #7373
Labels
auto-locked Outdated issues that have been locked by automation good first issue A good item for first time contributors to work on type: bug A confirmed bug or unintended behavior

Comments

@pradyunsg
Copy link
Member

I also found that pip doesn't always redacts the password. If you change the credentials to "valid" ones, then after doing pip install you get e.g.

$ pip install https://foo:bar@github.com/slafs
Collecting https://foo:****@github.com/slafs
  Downloading https://foo:bar@github.com/slafs
...

😅

Originally posted by @slafs in #6775 (comment)
@triage-new-issues triage-new-issues bot added the S: needs triage Issues/PRs that need to be triaged label Jul 24, 2019
@pradyunsg pradyunsg added the type: bug A confirmed bug or unintended behavior label Jul 24, 2019
@triage-new-issues triage-new-issues bot removed the S: needs triage Issues/PRs that need to be triaged label Jul 24, 2019
@xavfernandez xavfernandez added the good first issue A good item for first time contributors to work on label Jul 24, 2019
@xavfernandez
Copy link
Member

Cf #5773 for inspiration

@SharatChandar
Copy link

Can i try this ?

@pradyunsg
Copy link
Member Author

@SharatChandar I feel it would be best to work on one issue at a time. :)

@SharatChandar
Copy link

@pradyunsg Sure bro. Sorry.

@liam-stevenson
Copy link

I'd love to give this one a go - it'd be my first though!

@pradyunsg
Copy link
Member Author

@YoloSecurity Please feel free to. :)

@liam-stevenson
Copy link

@pradyunsg Had a go at making a fix and PR - first PR I've ever done though so feedback welcomed!

@xavfernandez xavfernandez mentioned this issue Aug 30, 2019
Closed
@Cactusmachete Cactusmachete mentioned this issue Nov 17, 2019
Merged
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Dec 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation good first issue A good item for first time contributors to work on type: bug A confirmed bug or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Redact passwords from index-url during download
4 participants
@xavfernandez @pradyunsg @SharatChandar @liam-stevenson