Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip shows password in index-url in the "Downloading <url>" message #6783

Closed
pradyunsg opened this issue Jul 24, 2019 · 7 comments · Fixed by #7373
Closed

pip shows password in index-url in the "Downloading <url>" message #6783

pradyunsg opened this issue Jul 24, 2019 · 7 comments · Fixed by #7373
Labels
auto-locked good first issue type: bug

Comments

@pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Jul 24, 2019

I also found that pip doesn't always redacts the password. If you change the credentials to "valid" ones, then after doing pip install you get e.g.

$ pip install https://foo:bar@github.com/slafs
Collecting https://foo:****@github.com/slafs
  Downloading https://foo:bar@github.com/slafs
...

😅

Originally posted by @slafs in #6775 (comment)

@triage-new-issues triage-new-issues bot added the S: needs triage label Jul 24, 2019
@pradyunsg pradyunsg added the type: bug label Jul 24, 2019
@triage-new-issues triage-new-issues bot removed the S: needs triage label Jul 24, 2019
@xavfernandez xavfernandez added the good first issue label Jul 24, 2019
@xavfernandez
Copy link
Member

@xavfernandez xavfernandez commented Jul 24, 2019

Cf #5773 for inspiration

@SharatChandar
Copy link

@SharatChandar SharatChandar commented Jul 26, 2019

Can i try this ?

@pradyunsg
Copy link
Member Author

@pradyunsg pradyunsg commented Jul 26, 2019

@SharatChandar I feel it would be best to work on one issue at a time. :)

@SharatChandar
Copy link

@SharatChandar SharatChandar commented Jul 29, 2019

@pradyunsg Sure bro. Sorry.

@liam-stevenson
Copy link

@liam-stevenson liam-stevenson commented Aug 4, 2019

I'd love to give this one a go - it'd be my first though!

@pradyunsg
Copy link
Member Author

@pradyunsg pradyunsg commented Aug 4, 2019

@YoloSecurity Please feel free to. :)

@liam-stevenson
Copy link

@liam-stevenson liam-stevenson commented Aug 4, 2019

@pradyunsg Had a go at making a fix and PR - first PR I've ever done though so feedback welcomed!

@lock lock bot added the auto-locked label Dec 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked good first issue type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants