Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail legacy install if .egg-info directory was not created #6998

Open
chrahunt opened this issue Sep 9, 2019 · 1 comment
Open

Fail legacy install if .egg-info directory was not created #6998

chrahunt opened this issue Sep 9, 2019 · 1 comment

Comments

@chrahunt
Copy link
Member

@chrahunt chrahunt commented Sep 9, 2019

What's the problem this feature will solve?

Currently on the legacy install code path (here) if execution of setup.py install ... didn't result in an .egg-info directory being created we trace a warning and continue.

This is bad because we will have installed an uninstallable package and the only penalty is a small warning which is very easy to miss.

Describe the solution you'd like

Instead of tracing a warning we should throw an exception.

This prevents additional packages from being installed and possibly hiding the warning from users.

Alternative Solutions

Continue tracing the warning as before.

Additional context

@pradyunsg

This comment has been minimized.

Copy link
Member

@pradyunsg pradyunsg commented Nov 6, 2019

Cool, let's give this the regular 2-release deprecation -- if no one raises major concerns w.r.t. this, we'll start raising an error there. :)

joeirimpan added a commit to joeirimpan/pykiteconnect that referenced this issue Feb 7, 2020
* pypa/pip#6998
Do not assume egg install for all setuptools version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.