Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible typo in warning message #7340

Closed
hallazzang opened this issue Nov 11, 2019 · 0 comments · Fixed by #7341
Closed

Possible typo in warning message #7340

hallazzang opened this issue Nov 11, 2019 · 0 comments · Fixed by #7341

Comments

@hallazzang
Copy link
Contributor

@hallazzang hallazzang commented Nov 11, 2019

Environment

  • pip version: master branch, and checked for 19.3.1
  • Python version: 3.8.0
  • OS: alpine linux (actually, it's a docker image python:3.8-alpine)

Description
As you see below, the warning message is using terms --build-options, --global-options and --install-options but what pip actually accepts are --build-option, --global-option and --install-option(without s at the end).

warnings.warn(
'Disabling all use of wheels due to the use of --build-options '
'/ --global-options / --install-options.', stacklevel=2,
)

Expected behavior
The warning message should say --build-option, --global-option and --install-option to not confuse users.

How to Reproduce

  1. Create a dummy requirements.txt with --install-option specified:
pip --install-option="-v"
  1. Run this command:
$ python3 -m pip install -r requirements.txt

Output

/usr/lib/python3/dist-packages/pip/req/req_file.py:150: UserWarning: Disabling all use of wheels due to the use of --build-options / --global-options / --install-options.
  cmdoptions.check_install_build_global(options, opts)
Collecting pip (from -r requirements.txt (line 1))
  Using cached https://files.pythonhosted.org/packages/ce/ea/9b445176a65ae4ba22dce1d93e4b5fe182f953df71a145f557cffaffc1bf/pip-19.3.1.tar.gz
Skipping bdist_wheel for pip, due to binaries being disabled for it.
Installing collected packages: pip
  Running setup.py install for pip ... done
Successfully installed pip-19.3.1
@triage-new-issues triage-new-issues bot added the triage label Nov 11, 2019
@chrahunt chrahunt added the type: bug label Nov 12, 2019
@triage-new-issues triage-new-issues bot removed the triage label Nov 12, 2019
@lock lock bot added the S: auto-locked label Dec 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.