-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip understand @# as empty tag/href in git source and breaks installation #7402
Comments
But why would the URL have such a combination? I feel the current behaviour is quite reasonable, and it’s up to the user to fix the URL. |
Due a human mistake
Well, it could be repaired by the user, but the user must know what is happening. The output message is very confusing. |
Hi @jsenin, thanks for bringing this up. If the revision part of the URL is empty then instead of continuing we could abort with an error message like:
Is that what you're looking for? |
Yes, this could help a lot
El 27 de noviembre de 2019 2:11:44 CET, Christopher Hunt <notifications@github.com> escribió:
…Hi @jsenin, thanks for bringing this up.
If the revision part of the URL is empty then instead of continuing we
could abort with an error message like:
> The URL
`git+https://github.com/AlexIoannides/py-package-template.git@#egg=py_pkg`
(from requirements.txt) has an empty revision (after `@`) which is not
supported. Include a revision after `@` or remove `@` from the URL.
Is that what you're looking for?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#7402 (comment)
--
Enviado desde mi dispositivo Android con K-9 Mail. Por favor, disculpa mi brevedad.
|
Hi @pradyunsg , @chrahunt , I have raised a PR for the same (#7927). Please have a look :) |
Environment
Description
When a git url contains a '@#' becomes an empty tag or href, that does not match with any fetched refs or tags and produces a : " fatal: ambiguous argument '': unknown revision or path not in the working tree."
When running into requirements.txt, breaks installation at this repo point
Expected behavior
Ignore the empty tag/href and continues
How to Reproduce
Setup requirements.txt with a source having a '@#' . e.g:
-e git+https://github.com/AlexIoannides/py-package-template.git@#egg=py_pkg
Then run 'pip install -r requirements.txt'. Installations works
Then run install again and you get the error ... an error occurs
fatal: ambiguous argument '': unknown revision or path not in the working tree.
The text was updated successfully, but these errors were encountered: