New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a package from the download cache fails the hash check, pip should purge that file from the cache and re-download #963

Closed
carljm opened this Issue May 29, 2013 · 5 comments

Comments

Projects
None yet
4 participants
@carljm
Contributor

carljm commented May 29, 2013

Right now if a file in the download cache fails the hash check, pip just gives up. It should instead purge that file from the cache and try again with a real download.

Any objections?

@dstufft

This comment has been minimized.

Show comment
Hide comment
@dstufft

dstufft May 29, 2013

Member

+1

Member

dstufft commented May 29, 2013

+1

@jezdez

This comment has been minimized.

Show comment
Hide comment
@jezdez

jezdez May 29, 2013

Contributor

+1 but make sure this is somewhere mentioned along the way, whether loud for users or just the log file, I don't care.

Contributor

jezdez commented May 29, 2013

+1 but make sure this is somewhere mentioned along the way, whether loud for users or just the log file, I don't care.

@carljm

This comment has been minimized.

Show comment
Hide comment
@carljm

carljm May 30, 2013

Contributor

Ok, I'm starting work on a PR for this.

@jezdez I agree, I think since even usage of a file from the download cache is loud by default, this should definitely be as well.

Contributor

carljm commented May 30, 2013

Ok, I'm starting work on a PR for this.

@jezdez I agree, I think since even usage of a file from the download cache is loud by default, this should definitely be as well.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Aug 9, 2014

Any way to simply make pip skip hash check or just ignore bad hashes? I need to modify a method name in one of the deps being downloaded. Real headache trying to work around.

ghost commented Aug 9, 2014

Any way to simply make pip skip hash check or just ignore bad hashes? I need to modify a method name in one of the deps being downloaded. Real headache trying to work around.

@mriehl

This comment has been minimized.

Show comment
Hide comment
@mriehl

mriehl Aug 10, 2014

@TechnikEmpire sounds like you should be monkey-patching the method in your app instead of tampering with the sources

mriehl commented Aug 10, 2014

@TechnikEmpire sounds like you should be monkey-patching the method in your app instead of tampering with the sources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment