New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for #1078 #1080

Merged
merged 2 commits into from Jul 27, 2013

Conversation

Projects
None yet
2 participants
@qwcode
Contributor

qwcode commented Jul 24, 2013

fixes mentioned in comments in #1078

the most controversial bit in here is changing the build dir name
(note that we changed the name in 1.3.1 due to security issues, and had no fallout from that)

jezdez added a commit that referenced this pull request Jul 27, 2013

@jezdez jezdez merged commit b262aa3 into pypa:1.4.X Jul 27, 2013

1 check passed

default The Travis CI build passed
Details
@qwcode

This comment has been minimized.

Show comment
Hide comment
@qwcode

qwcode Aug 1, 2013

Contributor

@jezdez, as mentioned over IRC, I did some manual testing on this. here's the sequence I went thru:

  • started with pip-1.4rc2 (which didn't have this fix)
  • validated that pip could not clean a build dir from /tmp/pip-build-root (which didn't have the delete marker file)
  • upgraded to tip of 1.4.x
  • confirmed it created a new /tmp/pip_build_root (different name) with the delete marker
  • then "sudo pip install peppercorn" and confirmed the build dir was cleaned.
  • then "sudo pip install --no-clean peppercorn" (which leaves /tmp/pip_build_root/peppercorn)
  • then "sudo pip uninstall peppercorn"
  • then "sudo pip install peppercorn" and got the PreviousBuildDirError as expected (and /tmp/pip_build_root/peppercorn was present)
  • then deleted /tmp/pip_build_root/peppercorn
  • then "sudo pip install peppercorn" which worked and /tmp/pip_build_root was deleted after
Contributor

qwcode commented Aug 1, 2013

@jezdez, as mentioned over IRC, I did some manual testing on this. here's the sequence I went thru:

  • started with pip-1.4rc2 (which didn't have this fix)
  • validated that pip could not clean a build dir from /tmp/pip-build-root (which didn't have the delete marker file)
  • upgraded to tip of 1.4.x
  • confirmed it created a new /tmp/pip_build_root (different name) with the delete marker
  • then "sudo pip install peppercorn" and confirmed the build dir was cleaned.
  • then "sudo pip install --no-clean peppercorn" (which leaves /tmp/pip_build_root/peppercorn)
  • then "sudo pip uninstall peppercorn"
  • then "sudo pip install peppercorn" and got the PreviousBuildDirError as expected (and /tmp/pip_build_root/peppercorn was present)
  • then deleted /tmp/pip_build_root/peppercorn
  • then "sudo pip install peppercorn" which worked and /tmp/pip_build_root was deleted after

This was referenced Aug 6, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment