New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setuptools upgrade fixes (and upgrade tests) #1092

Merged
merged 3 commits into from Jul 27, 2013

Conversation

Projects
None yet
1 participant
@qwcode
Contributor

qwcode commented Jul 27, 2013

2 fixes for setuptools upgrades (with better comments on the upgrade "hacks" we have)

  1. works using setuptools wheels when upgrading from >0.7 (#1091)
  2. works when a distribute-0.7.X wrapper is already installed from a previous upgrade

and I added tests for the upgrade scenarios

@@ -591,6 +591,7 @@ def install(self, install_options, global_options=(), root=None):
return
if self.is_wheel:
self.move_wheel_files(self.source_dir)
self.install_succeeded = True

This comment has been minimized.

@qwcode

qwcode Jul 27, 2013

Contributor

@dholth fyi, this was needed when wheel installs involve uninstalling a conflict, otherwise a temp dir is left. I noticed this when adding upgrade tests for setuptools (one of those was upgrading using a wheel (in response to #1091)

@qwcode

qwcode Jul 27, 2013

Contributor

@dholth fyi, this was needed when wheel installs involve uninstalling a conflict, otherwise a temp dir is left. I noticed this when adding upgrade tests for setuptools (one of those was upgrading using a wheel (in response to #1091)

qwcode added a commit that referenced this pull request Jul 27, 2013

Merge pull request #1092 from qwcode/upgrade_setuptools_wheel
setuptools upgrade fixes (and upgrade tests)

@qwcode qwcode merged commit d158999 into pypa:1.4.X Jul 27, 2013

1 check was pending

default The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment