New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmds {install,wheel} should return proper error code #1162

Merged
merged 1 commit into from Aug 27, 2013

Conversation

Projects
None yet
2 participants
@clarete
Contributor

clarete commented Aug 22, 2013

The pip executable was returning a successful status code (0) when
trying to install new packages with existing previous build directories.

from @qwcode: the reason to include in 1.4.2 is that this also contains a fix so that a PreviousBuildDirError prevents cleaning of the previous build dir (even when the build dir has a pip delete marker; if it previously exists with a delete marker, then it is safe to assume it was intentionally left, using --no-clean or --no-install, so should be left intact)

@qwcode

View changes

Show outdated Hide outdated pip/commands/install.py Outdated
@clarete

This comment has been minimized.

Show comment
Hide comment
@clarete

clarete Aug 23, 2013

Contributor

Thank you so much for your review @qwcode, I'll follow your instructions and improve the patch! :)

Contributor

clarete commented Aug 23, 2013

Thank you so much for your review @qwcode, I'll follow your instructions and improve the patch! :)

Cmds {install,wheel} should return proper error code
The `pip` executable was returning a successful status code (`0`) when
trying to install new packages with existing previous build directories.

qwcode added a commit that referenced this pull request Aug 27, 2013

Merge pull request #1162 from clarete/develop
Cmds {install,wheel} should return proper error code

@qwcode qwcode merged commit ecec569 into pypa:develop Aug 27, 2013

1 check passed

default The Travis CI build passed
Details
@qwcode

This comment has been minimized.

Show comment
Hide comment
@qwcode

qwcode Aug 27, 2013

Contributor

and I also backported into 1.4.X

Contributor

qwcode commented Aug 27, 2013

and I also backported into 1.4.X

@clarete

This comment has been minimized.

Show comment
Hide comment
@clarete

clarete Aug 27, 2013

Contributor

Thank you, I'm just excited to do more stuff on pip, you guys rock! :)

Contributor

clarete commented Aug 27, 2013

Thank you, I'm just excited to do more stuff on pip, you guys rock! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment