New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix --user script installs for wheels #1176

Merged
merged 2 commits into from Sep 1, 2013

Conversation

Projects
None yet
1 participant
@qwcode
Contributor

qwcode commented Aug 31, 2013

fixes #1163 (for 1.4.2)

this makes pip.locations.distutils_scheme not override "scripts" using pip's legacy bin_py logic.

I want to do more in develop (see concerns below), but want this to be minimal for the 1.4.2 patch release.
distutils_scheme is currently only used for wheel installs (not uninstalls), and for getting lib_path for --target installs

the concerns:

  • the use of distutils' classes over the setuptools versions in distutils_scheme (which btw, was taken from the wheel project)
  • the legacy bin_py logic needs to be dropped and defer to something like distutils_scheme
  • distutils_scheme has side-effects. it potentially creates the home dir or user base dir.
  • the awkwardness of creating a distutils install command to get at the scheme (although I can understand why)
@qwcode

This comment has been minimized.

Show comment
Hide comment
@qwcode

qwcode Aug 31, 2013

Contributor

hmm... all the test workers stalled on downloading scripttest

Contributor

qwcode commented Aug 31, 2013

hmm... all the test workers stalled on downloading scripttest

qwcode added a commit that referenced this pull request Sep 1, 2013

Merge pull request #1176 from qwcode/fix_1163_1.4
fix --user script installs for wheels

@qwcode qwcode merged commit 9da6362 into pypa:1.4.X Sep 1, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment