New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'pip search' support http proxy #1180

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@cula

cula commented Sep 1, 2013

I found I can't use pip search behind my company firewall using proxy. So I did the small changes.
My English is poor. I wish there not be errors in my comments...

cula added some commits Sep 1, 2013

Fix up the bug of that search ignore --proxy parameter.
Make search support http proxy.
Only http proxy is supported now.
@drakeguan

This comment has been minimized.

Show comment
Hide comment
@drakeguan

drakeguan Nov 18, 2013

It proves to work in my working environment.

drakeguan commented Nov 18, 2013

It proves to work in my working environment.

@conloos

This comment has been minimized.

Show comment
Hide comment
@conloos

conloos Jun 3, 2014

I use ubuntu 14.04 with pip version 1.5.4 and have the same problem.
"pip install --proxy user:pass@proxy:port " works
"pip search --proxy user:pass@proxy:port " dont work

conloos commented Jun 3, 2014

I use ubuntu 14.04 with pip version 1.5.4 and have the same problem.
"pip install --proxy user:pass@proxy:port " works
"pip search --proxy user:pass@proxy:port " dont work

@Ivoz

This comment has been minimized.

Show comment
Hide comment
@Ivoz

Ivoz Jun 3, 2014

Member

Unfortunately this is not python 3 compatible at all, which pip needs to be.

@cula you would want to pull appropriate modules from pip._vendor.six (see six's documentation) to make it python 3 compatible at the least.

This also needs to be rebased and PRed against develop branch, not master. I would suggest adding a custom XMLRPC class under pip.util.

Member

Ivoz commented Jun 3, 2014

Unfortunately this is not python 3 compatible at all, which pip needs to be.

@cula you would want to pull appropriate modules from pip._vendor.six (see six's documentation) to make it python 3 compatible at the least.

This also needs to be rebased and PRed against develop branch, not master. I would suggest adding a custom XMLRPC class under pip.util.

dstufft added a commit that referenced this pull request Jul 3, 2014

@Ivoz

This comment has been minimized.

Show comment
Hide comment
@Ivoz

Ivoz Jul 4, 2014

Member

Superceded by #1902 which uses a pip connection session. Thanks for your effort though, always appreciated.

Member

Ivoz commented Jul 4, 2014

Superceded by #1902 which uses a pip connection session. Thanks for your effort though, always appreciated.

@Ivoz Ivoz closed this Jul 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment