New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #772 (bug when setting PIP_EXISTS_ACTION='s') #1201

Merged
merged 3 commits into from Sep 16, 2013

Conversation

Projects
None yet
1 participant
@qwcode
Contributor

qwcode commented Sep 16, 2013

fixes #772 (bug when setting PIP_EXISTS_ACTION='s')

and prevents future bugs, if we ever had other choice options or non-'str' append options.

and adds some unit tests for our option parser.

qwcode added some commits Sep 16, 2013

When action is 'append', let's check value by value.
Previously, we used `convert_value' in all cases, which seems
to try to detect lists based on the value of nargs, but that fails
with lists of one item. This "worked" for 'str' options, because
the values don't get checked, but was failing for choice types
(see Issue #772), and would fail for other types like int.

qwcode added a commit that referenced this pull request Sep 16, 2013

Merge pull request #1201 from qwcode/issue_772
fix for #772 (bug when setting PIP_EXISTS_ACTION='s')

@qwcode qwcode merged commit 342ea2a into pypa:develop Sep 16, 2013

1 check was pending

default The Travis CI build is in progress
Details

@qwcode qwcode referenced this pull request Nov 8, 2013

Closed

exists-action in pip.conf #1309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment