New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make freeze ignore wsgiref #1369

Merged
merged 2 commits into from Dec 7, 2013

Conversation

Projects
None yet
2 participants
@msabramo
Contributor

msabramo commented Dec 6, 2013

This makes wsgiref (part of the standard library) not show up in pip freeze output.

I know that pip freeze --local also omits it, but I don't see why I should have to specify --local when I created a virtualenv with --no-site-packages.

@qwcode

This comment has been minimized.

Show comment
Hide comment
@qwcode

qwcode Dec 6, 2013

Contributor

I agree. also, go ahead and add it to the skip list in the pip list command.
https://github.com/pypa/pip/blob/develop/pip/commands/list.py#L18

Contributor

qwcode commented Dec 6, 2013

I agree. also, go ahead and add it to the skip list in the pip list command.
https://github.com/pypa/pip/blob/develop/pip/commands/list.py#L18

@msabramo

This comment has been minimized.

Show comment
Hide comment
@msabramo

msabramo Dec 6, 2013

Contributor

@qwcode: Cool -- see 81eb156

Contributor

msabramo commented Dec 6, 2013

@qwcode: Cool -- see 81eb156

@msabramo

This comment has been minimized.

Show comment
Hide comment
@msabramo

msabramo Dec 6, 2013

Contributor

Hmmm, the test failure was only in pypy; I doubt that it's related to this change.

https://travis-ci.org/pypa/pip/builds/15025497

Contributor

msabramo commented Dec 6, 2013

Hmmm, the test failure was only in pypy; I doubt that it's related to this change.

https://travis-ci.org/pypa/pip/builds/15025497

@qwcode

This comment has been minimized.

Show comment
Hide comment
@qwcode

qwcode Dec 6, 2013

Contributor

yea, it's unrelated.

Contributor

qwcode commented Dec 6, 2013

yea, it's unrelated.

@qwcode

This comment has been minimized.

Show comment
Hide comment
@qwcode

qwcode Dec 6, 2013

Contributor

going once, going twice... anyone? can't think of a reason not to do this?

Contributor

qwcode commented Dec 6, 2013

going once, going twice... anyone? can't think of a reason not to do this?

qwcode added a commit that referenced this pull request Dec 7, 2013

@qwcode qwcode merged commit 547720c into pypa:develop Dec 7, 2013

1 check failed

default The Travis CI build failed
Details

@msabramo msabramo deleted the msabramo:freeze_ignore_wsgiref branch Dec 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment