New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce 'retry' option #1444

Merged
merged 1 commit into from Mar 7, 2014

Conversation

Projects
None yet
2 participants
@novel

novel commented Jan 9, 2014

Add a 'retry' option which allows to configure how many
retries pip should make before giving up on HTTP request.

When the retries count is specified by user, its value is
passed to HTTPAdapter from requests which handles all
the underlying operations.

@novel

This comment has been minimized.

Show comment
Hide comment
@novel

novel Jan 14, 2014

I noticed that CI failed. The failure is only for pypy env and doesn't seem to be related to the commit itself. What should I do about it?

novel commented Jan 14, 2014

I noticed that CI failed. The failure is only for pypy env and doesn't seem to be related to the commit itself. What should I do about it?

Roman Bogorodskiy
Introduce 'retry' option
Add a 'retry' option which allows to configure how many
retries pip should make before giving up on HTTP request.

When the retries count is specified by user, its value is
passed to HTTPAdapter from requests which handles all
the underlying operations.

@novel novel closed this Feb 3, 2014

@novel novel deleted the novel:retries branch Feb 3, 2014

@novel novel restored the novel:retries branch Feb 3, 2014

@novel novel reopened this Feb 3, 2014

@novel

This comment has been minimized.

Show comment
Hide comment
@novel

novel commented Feb 20, 2014

ping?

@dstufft dstufft added this to the 1.6 milestone Feb 20, 2014

@dstufft

This comment has been minimized.

Show comment
Hide comment
@dstufft

dstufft Mar 7, 2014

Member

So reviewing this, my biggest concern is the retry option is only going to work for failed connections and timeouts. Another case of intermittent failure is a 503 error from the CDN servers on PyPI. It would be nice for this feature to take affect for all of the intermittent failure cases on PyPI. However that means we'll need to implement the retry logic ourselves.

Member

dstufft commented Mar 7, 2014

So reviewing this, my biggest concern is the retry option is only going to work for failed connections and timeouts. Another case of intermittent failure is a 503 error from the CDN servers on PyPI. It would be nice for this feature to take affect for all of the intermittent failure cases on PyPI. However that means we'll need to implement the retry logic ourselves.

@dstufft

This comment has been minimized.

Show comment
Hide comment
@dstufft

dstufft Mar 7, 2014

Member

On the other hand this is an improvement and we can always expand it later, so!

Member

dstufft commented Mar 7, 2014

On the other hand this is an improvement and we can always expand it later, so!

dstufft added a commit that referenced this pull request Mar 7, 2014

@dstufft dstufft merged commit c85150a into pypa:develop Mar 7, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment