New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pip to show files installed for wheels #1635

Merged
merged 1 commit into from Mar 15, 2014

Conversation

Projects
None yet
2 participants
@Ivoz
Member

Ivoz commented Mar 12, 2014

  • shortened looping logic in search_packages_info
  • added logic to find installed files for .dist-info's
  • Seemed to be off-by-one error for assert exceptions in test_show_with_files_not_found
  • changed ..._with_files_not_found to use an editable install for being unlistable
  • added test to assert a wheel's files are now listed :D

Also, sorted filepaths for some consistency

fixes #1484

Allow pip to show files installed for wheels
- shortened looping logic in search_packages_info
- added logic to find installed files for .dist-info's
- Seemed to be off-by-one error for assert exceptions in test_show_with_files_not_found
- changed ..._with_files_not_found to use an editable install for being unlistable
- added test to assert a wheel's files are now listed :D
@Ivoz

This comment has been minimized.

Show comment
Hide comment
@Ivoz

Ivoz Mar 12, 2014

Member

Comparison here

...and some git clones timed out on travis. 😞

Member

Ivoz commented Mar 12, 2014

Comparison here

...and some git clones timed out on travis. 😞

@Ivoz

This comment has been minimized.

Show comment
Hide comment
@Ivoz

Ivoz Mar 12, 2014

Member

Lastly, the file paths are at the moment returned with the same canonical relative dir as previous, i.e relative to .{egg,dist}-info.

I actually think in a further PR this could be changed in 1.6 (or 1.7 conservatively) to be relative to the relevant site-packages directory, as that is both mentioned in the Location: part of show -f's output (so joining the location and the paths listed would result in proper filenames, unlike current) and makes more sense to me.

Member

Ivoz commented Mar 12, 2014

Lastly, the file paths are at the moment returned with the same canonical relative dir as previous, i.e relative to .{egg,dist}-info.

I actually think in a further PR this could be changed in 1.6 (or 1.7 conservatively) to be relative to the relevant site-packages directory, as that is both mentioned in the Location: part of show -f's output (so joining the location and the paths listed would result in proper filenames, unlike current) and makes more sense to me.

qwcode added a commit that referenced this pull request Mar 15, 2014

Merge pull request #1635 from Ivoz/wheelfiles
Allow pip to show files installed for wheels

@qwcode qwcode merged commit 0690ff8 into pypa:develop Mar 15, 2014

1 check failed

default The Travis CI build failed
Details

@Ivoz Ivoz deleted the Ivoz:wheelfiles branch Jun 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment