New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1456 disable ssl warning for localhost #1718

Closed
wants to merge 4 commits into
base: develop
from

Conversation

Projects
None yet
7 participants
@grzn
Contributor

grzn commented Apr 14, 2014

No description provided.

@Ivoz

This comment has been minimized.

Show comment
Hide comment
@Ivoz

Ivoz Apr 16, 2014

Member

IMO it would be nice if this was a default set of {localhost, 127.0.0.1} and you could add hosts to it through a general pip option, so others could add, for instance, a different address that was on their lan that didn't need to be under https.

Otherwise, it'd be nice to figure out a test or two for this.

Member

Ivoz commented Apr 16, 2014

IMO it would be nice if this was a default set of {localhost, 127.0.0.1} and you could add hosts to it through a general pip option, so others could add, for instance, a different address that was on their lan that didn't need to be under https.

Otherwise, it'd be nice to figure out a test or two for this.

@grzn

This comment has been minimized.

Show comment
Hide comment
@grzn

grzn Apr 16, 2014

Contributor
  • I thought about adding 127.0.0.1 but it didn't seem likely to me that someone will fetch packages from http://127.0.0.1/something -- easier to stay with hostnames. but fine; I'll add it; oh and I'm sticking with tuples for 2.6 support
  • didn't see the tests for PackageFinder before; I'll add some
Contributor

grzn commented Apr 16, 2014

  • I thought about adding 127.0.0.1 but it didn't seem likely to me that someone will fetch packages from http://127.0.0.1/something -- easier to stay with hostnames. but fine; I'll add it; oh and I'm sticking with tuples for 2.6 support
  • didn't see the tests for PackageFinder before; I'll add some
@grzn

This comment has been minimized.

Show comment
Hide comment
@grzn

grzn Apr 16, 2014

Contributor

Still not sure about the pip option, about how it should be named

Contributor

grzn commented Apr 16, 2014

Still not sure about the pip option, about how it should be named

@Ivoz Ivoz added the enhancement label Apr 16, 2014

@dstufft

This comment has been minimized.

Show comment
Hide comment
@dstufft

dstufft Apr 23, 2014

Member

Probably something like

$ pip install --safe-host wheels.local --safe-host pypi.local Django

I'm guessing that --safe-host would be additive to the default ones.

Member

dstufft commented Apr 23, 2014

Probably something like

$ pip install --safe-host wheels.local --safe-host pypi.local Django

I'm guessing that --safe-host would be additive to the default ones.

@dfleury

This comment has been minimized.

Show comment
Hide comment
@dfleury

dfleury May 5, 2014

here in globo.com, we have a internal host of pypi and i'm getting this annoying warn during the installation of 183 packages...
this --safe-host option would be nice!

dfleury commented May 5, 2014

here in globo.com, we have a internal host of pypi and i'm getting this annoying warn during the installation of 183 packages...
this --safe-host option would be nice!

@hpk42

This comment has been minimized.

Show comment
Hide comment
@hpk42

hpk42 Jul 7, 2014

Just chiming in to say that just having localhost not generate the warning would be a win already. Adding an option to extend the internal list is fine but not neccessary to get rid of unneccessary messages for many.

hpk42 commented Jul 7, 2014

Just chiming in to say that just having localhost not generate the warning would be a win already. Adding an option to extend the internal list is fine but not neccessary to get rid of unneccessary messages for many.

r1chardj0n3s added a commit to r1chardj0n3s/pip that referenced this pull request Aug 11, 2014

@jezdez

This comment has been minimized.

Show comment
Hide comment
@jezdez

jezdez Aug 11, 2014

Contributor

Closing in favor of #1967

Contributor

jezdez commented Aug 11, 2014

Closing in favor of #1967

@jezdez jezdez closed this Aug 11, 2014

@Ivoz Ivoz referenced this pull request Dec 9, 2014

Closed

Add --no-warn-https option #2158

@msabramo

This comment has been minimized.

Show comment
Hide comment
@msabramo

msabramo Dec 9, 2014

Contributor

#2158 is an attempt to make it so that you can additional "safe hosts" to not warn about HTTPS for (in addition to the defaults of localhost and 127.0.0.1).

Contributor

msabramo commented Dec 9, 2014

#2158 is an attempt to make it so that you can additional "safe hosts" to not warn about HTTPS for (in addition to the defaults of localhost and 127.0.0.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment