GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@pfmoore would be awesome if you'd be able to test this also works on windows, i.e you stop getting output like #1618 (comment) (number of log lines in idempotent)
@Ivoz I'll try to get round to it, but probably not till after Easter - it's crazy busy round here at the moment :-( If I haven't responded by next week, ping me about it.
Skip adding a duplicated consumer to pip's logger
lgtm, but we should add a test to tests.unit.test_log
Sorry for nitpicking but wouldn't it be more natural to postpone doing anything with consumer unless it's going to be added? I mean to move this code inside the next if not consumer_exists:.
if not consumer_exists:
Probably a micro-optimization, but its not harmful either :) See next commit
Add tests, improve code addition
@qwcode these tests look good to you? Otherwise would like to merge this
Works on Windows (including the colours remaining as expected). So looks good to me - sorry for the delay.
Use pytest monkeypatching for sys.platform
I swear I looked for ages at pytest.patch for how to patch stuff but couldn't figure it out... turns out you need monkeys to help you.
Add changelog for this PR
@pfmoore cheers for checking its all good on the Windows side ^_^ Also why I added the second test.
@Ivoz, tests look ok to me.
Cheers @qwcode 😁