New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display help for completion command. #1810

Merged
merged 1 commit into from Mar 4, 2016

Conversation

Projects
None yet
6 participants
@nvdv
Contributor

nvdv commented May 10, 2014

I spent 10 minutes figuring out how to set up pip auto-completion for bash. Now it should be easier.

Review on Reviewable

@msabramo

This comment has been minimized.

Show comment
Hide comment
@msabramo

msabramo Dec 21, 2014

Contributor

👍

I had no idea that pip completion existed.

Contributor

msabramo commented Dec 21, 2014

👍

I had no idea that pip completion existed.

@qwcode

This comment has been minimized.

Show comment
Hide comment
@qwcode

qwcode Dec 21, 2014

Contributor

there are docs for this:
https://pip.pypa.io/en/latest/user_guide.html#command-completion

but yes, it makes sense to expose the command I think.

Contributor

qwcode commented Dec 21, 2014

there are docs for this:
https://pip.pypa.io/en/latest/user_guide.html#command-completion

but yes, it makes sense to expose the command I think.

@msabramo

This comment has been minimized.

Show comment
Hide comment
@msabramo

msabramo Dec 24, 2014

Contributor

What do you think, @dstufft and @pfmoore ?

Contributor

msabramo commented Dec 24, 2014

What do you think, @dstufft and @pfmoore ?

@msabramo

This comment has been minimized.

Show comment
Hide comment
@msabramo

msabramo Jan 16, 2015

Contributor

👍

Contributor

msabramo commented Jan 16, 2015

👍

@pfmoore

This comment has been minimized.

Show comment
Hide comment
@pfmoore

pfmoore Jan 16, 2015

Member

No opinion, personally. It seems harmless enough, but as I don't use bash this isn't relevant for me.

Member

pfmoore commented Jan 16, 2015

No opinion, personally. It seems harmless enough, but as I don't use bash this isn't relevant for me.

@nvdv

This comment has been minimized.

Show comment
Hide comment
@nvdv

nvdv Jun 26, 2015

Contributor

Just as reminder: merging this can make life of Bash or Zsh users little easier :)

Contributor

nvdv commented Jun 26, 2015

Just as reminder: merging this can make life of Bash or Zsh users little easier :)

@xavfernandez xavfernandez added this to the 8.1 milestone Feb 24, 2016

@xavfernandez

This comment has been minimized.

Show comment
Hide comment
@xavfernandez

xavfernandez Feb 24, 2016

Contributor

But if this is merged, the whole "hidden" command code can also go away right ?
Is there any good reason to hide some commands ?

Contributor

xavfernandez commented Feb 24, 2016

But if this is merged, the whole "hidden" command code can also go away right ?
Is there any good reason to hide some commands ?

@dstufft

This comment has been minimized.

Show comment
Hide comment
@dstufft

dstufft Mar 3, 2016

Member

Going to dump this from the 8.1 milestone since I don't think it's urgent for that.

Member

dstufft commented Mar 3, 2016

Going to dump this from the 8.1 milestone since I don't think it's urgent for that.

@dstufft dstufft removed this from the 8.1 milestone Mar 3, 2016

@xavfernandez

This comment has been minimized.

Show comment
Hide comment
@xavfernandez

xavfernandez Mar 3, 2016

Contributor

@dstufft any opinion on showing pip completion method ? I could quickly fix this for 8.1.

Contributor

xavfernandez commented Mar 3, 2016

@dstufft any opinion on showing pip completion method ? I could quickly fix this for 8.1.

@dstufft

This comment has been minimized.

Show comment
Hide comment
@dstufft

dstufft Mar 3, 2016

Member

No opinion, doesn't matter to me either way.

Member

dstufft commented Mar 3, 2016

No opinion, doesn't matter to me either way.

@xavfernandez xavfernandez referenced this pull request Mar 3, 2016

Merged

Unhide completion #3536

@xavfernandez xavfernandez merged commit 87b18f5 into pypa:develop Mar 4, 2016

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@nvdv nvdv deleted the nvdv:develop branch Sep 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment