fix for #1825 #1831
Closed
fix for #1825 #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Purge the |
|
closing. change was brought in thru PR #1838 to 1.5.X, and then merged to develop |
Couldn't pip (for sdists) unpack just setup.py first to see what's the name of the requirement? Would this make handling wheels and sdists uniform thus rendering "unnamed requirement" code path needless? |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #1825 with two new tests.
(for the test wheels I added, I also added the src to
tests/data/srcthe change is to use the
nameandversionfrom the wheel file to build theInstallRequirementso that it has a non-Nonereqattribute. Whenreqis None, the "unnamed requirement" code path (see #1689) is used, which only works for sdists.