Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Proposed fix to #1180 (and maybe #932 & #1104) #1902
referenced this pull request
Jul 1, 2014
Hey, sorry this took so long to review, I've been debugging a really wonky issue.
This looks pretty good, only thing I'd ask is can you change it so that you have the session in a context manager? like:
with self._build_session(...) as session: pass # Do stuff with the session here
This way the connection pool will get closed explicitly? You can see I've made this change to the other commands in #1882.