New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #1519 from dstufft/remove-dependency-links" #1955

Merged
merged 1 commit into from Aug 4, 2014

Conversation

Projects
None yet
4 participants
@dstufft
Member

dstufft commented Aug 1, 2014

This reverts commit da02f07, reversing changes made to 2ad8888.

Conflicts:
CHANGES.txt
pip/commands/freeze.py
pip/commands/list.py
pip/commands/wheel.py
pip/index.py
pip/req/req_set.py
pip/vcs/subversion.py

Revert "Merge pull request #1519 from dstufft/remove-dependency-links"
This reverts commit da02f07, reversing
changes made to 2ad8888.

Conflicts:
	CHANGES.txt
	pip/commands/freeze.py
	pip/commands/list.py
	pip/commands/wheel.py
	pip/index.py
	pip/req/req_set.py
	pip/vcs/subversion.py
@Ivoz

This comment has been minimized.

Show comment
Hide comment
@Ivoz

Ivoz Aug 2, 2014

Member

You write any discussion on what caused change in opinion from removing it?

Member

Ivoz commented Aug 2, 2014

You write any discussion on what caused change in opinion from removing it?

@dstufft

This comment has been minimized.

Show comment
Hide comment
@dstufft

dstufft Aug 2, 2014

Member

Nothing in particular. I've seen a number of people worried that this change hurts their ability to distribute their private packages. Even Metadata 2.0 recognizes this use case however I'm not sure that there is a good reason to break this use case for people until Metadata 2.0 exists and can replace it.

Member

dstufft commented Aug 2, 2014

Nothing in particular. I've seen a number of people worried that this change hurts their ability to distribute their private packages. Even Metadata 2.0 recognizes this use case however I'm not sure that there is a good reason to break this use case for people until Metadata 2.0 exists and can replace it.

@qwcode

This comment has been minimized.

Show comment
Hide comment
@qwcode

qwcode Aug 3, 2014

Contributor

+1

Contributor

qwcode commented Aug 3, 2014

+1

dstufft added a commit that referenced this pull request Aug 4, 2014

Merge pull request #1955 from dstufft/revert-dep-links-removal
Revert "Merge pull request #1519 from dstufft/remove-dependency-links"

@dstufft dstufft merged commit d420497 into pypa:develop Aug 4, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@dstufft dstufft deleted the dstufft:revert-dep-links-removal branch Aug 4, 2014

@pradyunsg

This comment has been minimized.

Show comment
Hide comment
@pradyunsg

pradyunsg Dec 8, 2017

Member

@dstufft @qwcode As on today, what needs to be done to remove dependency link support from pip?

Is there some existing discussion for this? #4187 is in quite the opposite direction. Does this need to happen on Warehouse?

Member

pradyunsg commented Dec 8, 2017

@dstufft @qwcode As on today, what needs to be done to remove dependency link support from pip?

Is there some existing discussion for this? #4187 is in quite the opposite direction. Does this need to happen on Warehouse?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment