New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haypo req markers #2134

Merged
merged 4 commits into from Nov 20, 2014

Conversation

Projects
None yet
2 participants
@dstufft
Member

dstufft commented Nov 20, 2014

Rebases @haypo's patch in #1472 and fixes a few small issues with it.

Closes #1472 and Fixes #1433

vstinner and others added some commits Jan 14, 2014

Fix issue #1433: parse requirements in markers
* InstallRequirement supports PEP 426 markers
* RequirementSet.add_requirement() ignores an InstallRequirement if
  markers don't match.
Support markers in requirements
It's now possible to specify requirements markers in requirements.
Examples::

    futures; python_version < '2.7'
    mock; python_version < '3.3'
    nose
    ordereddict; python_version < '2.7'
    unittest2; python_version < '2.7'

The separator is "; ". For convinience, ";" alone is also supported, but
no in URLs. The ";" character is a legit and common character in an URL.
Example of valid URL without markers::

    http://foo.com/?p=bar.git;a=snapshot;h=v0.1;sf=tgz

Example of URL with markers::

    http://foo.com/?p=bar.git;a=snapshot;h=v0.1;sf=tgz; python_version < '3.3'

dstufft added a commit that referenced this pull request Nov 20, 2014

@dstufft dstufft merged commit fef3bd0 into pypa:develop Nov 20, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@dstufft dstufft deleted the dstufft:haypo-req-markers branch Nov 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment