New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install headers into the project name subdirectory in virtualenvs #2421

Merged
merged 1 commit into from Apr 7, 2015

Conversation

Projects
None yet
3 participants
@radhermit
Contributor

radhermit commented Feb 12, 2015

This helps keep the header namespace cleaner instead of putting
everything in the top level include directory related to the python
version.

Install headers into the project name subdirectory in virtualenvs
This helps keep the header namespace cleaner instead of putting
everything in the top level include directory related to the python
version.
@mgorny

This comment has been minimized.

Show comment
Hide comment
@mgorny

mgorny Feb 12, 2015

Well, the stronger argument is that this is what distutils does by default. Virtualenv changing that simply breaks packages.

mgorny commented Feb 12, 2015

Well, the stronger argument is that this is what distutils does by default. Virtualenv changing that simply breaks packages.

dstufft added a commit that referenced this pull request Apr 7, 2015

Merge pull request #2421 from radhermit/venv-install-headers
Install headers into the project name subdirectory in virtualenvs

@dstufft dstufft merged commit acdaee3 into pypa:develop Apr 7, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@radhermit radhermit deleted the radhermit:venv-install-headers branch Apr 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment