Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on pywin32 as ctypes should always be available #2467

Merged
merged 1 commit into from Mar 2, 2015

Conversation

@pfmoore
Copy link
Member

pfmoore commented Mar 2, 2015

Avoids an issue where pip can't uninstall pywin32 because pip itself loads the pywin32 DLLs, and so they are locked when pip needs to delete them. When pywin32 isn't available the code falls back to ctypes anyway - there's no benefit to using pywin32 over ctypes, and ctypes is always available on Windows, so this should not cause an issue for anyone.

@pfmoore pfmoore force-pushed the pfmoore:remove_pywin32 branch to d83b1bd Mar 2, 2015
pfmoore added a commit that referenced this pull request Mar 2, 2015
Remove dependency on pywin32 as ctypes should always be available
@pfmoore pfmoore merged commit 1e16501 into pypa:develop Mar 2, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pfmoore
Copy link
Member Author

pfmoore commented Mar 2, 2015

@dstufft can this change be included in the next release please?

@pfmoore
Copy link
Member Author

pfmoore commented Mar 2, 2015

Fixes a bug reported on IRC (no issue raised here AFAICT, though...)

@lock lock bot added the S: auto-locked label Jun 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.