Remove dependency on pywin32 as ctypes should always be available #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfmoore
added a commit
that referenced
this pull request
Mar 2, 2015
Remove dependency on pywin32 as ctypes should always be available
|
@dstufft can this change be included in the next release please? |
|
Fixes a bug reported on IRC (no issue raised here AFAICT, though...) |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids an issue where pip can't uninstall pywin32 because pip itself loads the pywin32 DLLs, and so they are locked when pip needs to delete them. When pywin32 isn't available the code falls back to ctypes anyway - there's no benefit to using pywin32 over ctypes, and ctypes is always available on Windows, so this should not cause an issue for anyone.