New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wheel tag for py2-none-[arch] / py3-none-[arch] #2561

Merged
merged 2 commits into from Apr 7, 2015

Conversation

Projects
None yet
5 participants
@dholth
Member

dholth commented Mar 17, 2015

To support platform-specific but not Python ABI specific wheels.

add wheel tag for py2-none-[arch] / py3-none-[arch]
To support platform-specific but not Python ABI specific wheels.
Show outdated Hide outdated pip/pep425tags.py
@sigmavirus24

This comment has been minimized.

Show comment
Hide comment
@sigmavirus24

sigmavirus24 Apr 2, 2015

Member

No tests for this?

Member

sigmavirus24 commented Apr 2, 2015

No tests for this?

@dholth

This comment has been minimized.

Show comment
Hide comment
@dholth

dholth Apr 2, 2015

Member

Can you think of a better test than to re-generate the same tag in a test, and assert that it is in the list?

Member

dholth commented Apr 2, 2015

Can you think of a better test than to re-generate the same tag in a test, and assert that it is in the list?

@@ -113,6 +113,9 @@ def get_supported(versions=None, noarch=False):
for arch in arches:
supported.append(('%s%s' % (impl, versions[0]), abi, arch))
# Has binaries, does not use the Python API:
supported.append(('py%s' % (versions[0][0]), 'none', arch))

This comment has been minimized.

@rbtcollins

rbtcollins Apr 2, 2015

Contributor

So this code depends on the versions[0][0] input and on the arch... whats the right behaviour when noarch is false? A test for it might be to assert that
get_supported([['2']], False) results in ('py2', 'none', local_arch) in the output, and for get_support([['2]], True) to do ??? [whats the right thing here?].

We could make this more meaningfully testable by pushing all the calculation to pure functions, and having get_supported just do the querying and then call those functions

@rbtcollins

rbtcollins Apr 2, 2015

Contributor

So this code depends on the versions[0][0] input and on the arch... whats the right behaviour when noarch is false? A test for it might be to assert that
get_supported([['2']], False) results in ('py2', 'none', local_arch) in the output, and for get_support([['2]], True) to do ??? [whats the right thing here?].

We could make this more meaningfully testable by pushing all the calculation to pure functions, and having get_supported just do the querying and then call those functions

This comment has been minimized.

@dholth

dholth Apr 2, 2015

Member

I've noticed that this might go in the 'for arch in arches' loop that helps OSX folks out.

If noarch is True, this line won't run and the tag won't be in the list.

@dholth

dholth Apr 2, 2015

Member

I've noticed that this might go in the 'for arch in arches' loop that helps OSX folks out.

If noarch is True, this line won't run and the tag won't be in the list.

This comment has been minimized.

@rbtcollins

rbtcollins Apr 2, 2015

Contributor

Seems like thats worth capturing as intent somewhere. Either docs / comments or tests. IMNSHO.

@rbtcollins

rbtcollins Apr 2, 2015

Contributor

Seems like thats worth capturing as intent somewhere. Either docs / comments or tests. IMNSHO.

dstufft added a commit that referenced this pull request Apr 7, 2015

Merge pull request #2561 from dholth/develop
add wheel tag for py2-none-[arch] / py3-none-[arch]

@dstufft dstufft merged commit 062c196 into pypa:develop Apr 7, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment