New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: ignore stdlib pkgs like wsgiref #2636

Merged
merged 1 commit into from Apr 7, 2015

Conversation

Projects
None yet
3 participants
@dstufft
Member

dstufft commented Apr 7, 2015

Closes #2602

@rbtcollins

This comment has been minimized.

Show comment
Hide comment
@rbtcollins

rbtcollins Apr 7, 2015

Contributor

This should work, and both checks are needed - without the first one requirements could contain argparse, without the second one we'll unnecessarily download and examine argparse.

I think this would be a bit less internally redundant with a helper:

def _skip_req(req):
if ....
logger..
return True
return False

then you can say:
if self._skip_req(req_to_install):
continue

and
if self._skip_req(req_to_install);
return []

Contributor

rbtcollins commented Apr 7, 2015

This should work, and both checks are needed - without the first one requirements could contain argparse, without the second one we'll unnecessarily download and examine argparse.

I think this would be a bit less internally redundant with a helper:

def _skip_req(req):
if ....
logger..
return True
return False

then you can say:
if self._skip_req(req_to_install):
continue

and
if self._skip_req(req_to_install);
return []

install: ignore stdlib pkgs like wsgiref
in requirements files

This allows a `pip install -r requirements.txt` to succeed even if it
was generated with an older version of pip that included stuff like
`wsgiref==0.1.2` in it.

dstufft added a commit that referenced this pull request Apr 7, 2015

Merge pull request #2636 from dstufft/ignore-stdlib
install: ignore stdlib pkgs like wsgiref

@dstufft dstufft merged commit 4be28b6 into pypa:develop Apr 7, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dstufft dstufft deleted the dstufft:ignore-stdlib branch Apr 7, 2015

dstufft added a commit to dstufft/pip that referenced this pull request Apr 7, 2015

dstufft added a commit to dstufft/pip that referenced this pull request Apr 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment