New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issue #1236. #2785

Merged
merged 2 commits into from May 19, 2015

Conversation

Projects
None yet
5 participants
@mrtrumbe
Contributor

mrtrumbe commented May 14, 2015

A potential solution to #1236 where we check for [extra1,extra2] formatted extras at the end of all requirement specifications, either editable or not.

I recreated the commits and pull request to fix the munged contributor when I did the original commits.

mrtrumbe added some commits May 14, 2015

Added tests for extras specifications as part of requirement parsing.…
… Breaking tests are in preparation of a fix for #1236.
Addresses issue #1236. Extras can now be specified on file/directory-…
…like requirement specifications as well as url requirement specifications.

@mrtrumbe mrtrumbe referenced this pull request May 17, 2015

Closed

Fixed issue #1236. #2750

@rbtcollins

This comment has been minimized.

Show comment
Hide comment
@rbtcollins

rbtcollins May 19, 2015

Contributor

So this makes

pip install .[test] work - yay.

However pip install file://path/to/thing[test] doesn't - but it doesn't work in develop either, so its not a regression in this patch.

+1.

Contributor

rbtcollins commented May 19, 2015

So this makes

pip install .[test] work - yay.

However pip install file://path/to/thing[test] doesn't - but it doesn't work in develop either, so its not a regression in this patch.

+1.

dstufft added a commit that referenced this pull request May 19, 2015

@dstufft dstufft merged commit 7497073 into pypa:develop May 19, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

dstufft added a commit that referenced this pull request May 19, 2015

assert len(req.extras) == 2
assert req.extras[0] == 'ex1'
assert req.extras[1] == 'ex2'

This comment has been minimized.

@qwcode

qwcode May 30, 2015

Contributor

these 4 tests are in the wrong place.
this test class is for processing lines in a requirements file.
you're not testing the process_line method in these tests.

@qwcode

qwcode May 30, 2015

Contributor

these 4 tests are in the wrong place.
this test class is for processing lines in a requirements file.
you're not testing the process_line method in these tests.

This comment has been minimized.

@mrtrumbe

mrtrumbe May 30, 2015

Contributor

Yeah, looking at it again, I'd probably move them into tests/unit/test_req.py in the TestInstallRequirement class. Does that look more reasonable to you? If so, I can put together a pull request with the change.

@mrtrumbe

mrtrumbe May 30, 2015

Contributor

Yeah, looking at it again, I'd probably move them into tests/unit/test_req.py in the TestInstallRequirement class. Does that look more reasonable to you? If so, I can put together a pull request with the change.

This comment has been minimized.

@qwcode

qwcode May 30, 2015

Contributor

yea, that would be great, thanks

@qwcode

qwcode May 30, 2015

Contributor

yea, that would be great, thanks

@marabout2015

This comment has been minimized.

Show comment
Hide comment
@marabout2015

marabout2015 Mar 23, 2018

I'm glad this specification works for tar.gz, and I see it also works for .whl. How do specify extras when I need to install from a URL? The package is listed in a conda environment.yml, and the system in which I'm doing the install requires that I use a URL.

marabout2015 commented Mar 23, 2018

I'm glad this specification works for tar.gz, and I see it also works for .whl. How do specify extras when I need to install from a URL? The package is listed in a conda environment.yml, and the system in which I'm doing the install requires that I use a URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment