New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for svn related bug #1062 #3346

Merged
merged 2 commits into from Jan 13, 2016

Conversation

Projects
None yet
2 participants
@dalito
Contributor

dalito commented Jan 7, 2016

This avoids an exception(IOError) for "pip freeze" and "pip list" commands that is related to subversion >= 1.7. The issue was reported a while ago and is still present in pip 7.1.2 (#1062).

The fix is simple and may not require a test. I would have added a test but I could not find tests for subversion to build upon. I only saw tests for the subversion command line interface but no tests related to the subversion repository structure which changed between subversion 1.6 and 1.7.

Review on Reviewable

@xavfernandez xavfernandez added this to the 8.0 milestone Jan 8, 2016

@xavfernandez

This comment has been minimized.

Show comment
Hide comment
@xavfernandez

xavfernandez Jan 8, 2016

Contributor

Seems simple enough. It just needs a changelog and should be good to go.

BTW, do you know any good reason pip should keep the two other way to get repository informations: https://github.com/pypa/pip/blob/97f376f/pip/vcs/subversion.py#L168-L180

svn info seems to exist since subversion 1.2 which was released in 2005. Maybe we could drop support for previous subversion versions ? cc @dstufft @qwcode @pfmoore

Contributor

xavfernandez commented Jan 8, 2016

Seems simple enough. It just needs a changelog and should be good to go.

BTW, do you know any good reason pip should keep the two other way to get repository informations: https://github.com/pypa/pip/blob/97f376f/pip/vcs/subversion.py#L168-L180

svn info seems to exist since subversion 1.2 which was released in 2005. Maybe we could drop support for previous subversion versions ? cc @dstufft @qwcode @pfmoore

@dalito

This comment has been minimized.

Show comment
Hide comment
@dalito

dalito Jan 9, 2016

Contributor

I just added a note to the changelog.

Maybe we could drop support for previous subversion versions?

I checked if there are issues reported related to previous subversion versions but did not see any. So I wonder if it is worth to risk breaking something.

Could you merge this PR? Dropping support for old subversion versions should be probably done in a separate one.

Contributor

dalito commented Jan 9, 2016

I just added a note to the changelog.

Maybe we could drop support for previous subversion versions?

I checked if there are issues reported related to previous subversion versions but did not see any. So I wonder if it is worth to risk breaking something.

Could you merge this PR? Dropping support for old subversion versions should be probably done in a separate one.

xavfernandez added a commit that referenced this pull request Jan 13, 2016

@xavfernandez xavfernandez merged commit 99aa8f9 into pypa:develop Jan 13, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xavfernandez

This comment has been minimized.

Show comment
Hide comment
@xavfernandez

xavfernandez Jan 13, 2016

Contributor

Thanks for your PR :)

Contributor

xavfernandez commented Jan 13, 2016

Thanks for your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment