Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix for svn related bug #1062 #3346
This avoids an exception(IOError) for "pip freeze" and "pip list" commands that is related to subversion >= 1.7. The issue was reported a while ago and is still present in pip 7.1.2 (#1062).
The fix is simple and may not require a test. I would have added a test but I could not find tests for subversion to build upon. I only saw tests for the subversion command line interface but no tests related to the subversion repository structure which changed between subversion 1.6 and 1.7.
Seems simple enough. It just needs a changelog and should be good to go.
BTW, do you know any good reason pip should keep the two other way to get repository informations: https://github.com/pypa/pip/blob/97f376f/pip/vcs/subversion.py#L168-L180
I just added a note to the changelog.
I checked if there are issues reported related to previous subversion versions but did not see any. So I wonder if it is worth to risk breaking something.
Could you merge this PR? Dropping support for old subversion versions should be probably done in a separate one.