New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installing modules from a vcs subdirectory in non-editable mode #3466

Merged
merged 7 commits into from Feb 10, 2016

Conversation

Projects
None yet
2 participants
@sbidoul
Contributor

sbidoul commented Feb 8, 2016

Fixes #3217

Review on Reviewable

Show outdated Hide outdated pip/index.py Outdated
@sbidoul

This comment has been minimized.

Show comment
Hide comment
@sbidoul

sbidoul Feb 8, 2016

Contributor

I factored out the code in a setup_py_dir property, and adapted the wheel command too.

Contributor

sbidoul commented Feb 8, 2016

I factored out the code in a setup_py_dir property, and adapted the wheel command too.

@xavfernandez

This comment has been minimized.

Show comment
Hide comment
@xavfernandez

xavfernandez Feb 8, 2016

Contributor

Great job ! It's much cleaner 👍

This also means you can remove _build_editable_options and all references to editable_options.

And maybe add a few tests in

class TestLink(object):
for subdirectory_fragment

Contributor

xavfernandez commented Feb 8, 2016

Great job ! It's much cleaner 👍

This also means you can remove _build_editable_options and all references to editable_options.

And maybe add a few tests in

class TestLink(object):
for subdirectory_fragment

@xavfernandez xavfernandez added this to the 8.1 milestone Feb 8, 2016

@sbidoul

This comment has been minimized.

Show comment
Hide comment
@sbidoul

sbidoul Feb 9, 2016

Contributor

@xavfernandez I love adding features while removing code at the same time 😄

I removed editable_options, added the test for link fragments, and added subdirectory support for pip download.

Now I don't understand why travis fails on pypy, previous run was ok. Must be a transient error?

Contributor

sbidoul commented Feb 9, 2016

@xavfernandez I love adding features while removing code at the same time 😄

I removed editable_options, added the test for link fragments, and added subdirectory support for pip download.

Now I don't understand why travis fails on pypy, previous run was ok. Must be a transient error?

)
if not options or 'egg' not in options:
req = _build_req_from_url(editable_req)

This comment has been minimized.

@xavfernandez

xavfernandez Feb 9, 2016

Contributor

Hmm it looks like this should not go away (or it should be indicated as backward incompatible, and deleted).

@xavfernandez

xavfernandez Feb 9, 2016

Contributor

Hmm it looks like this should not go away (or it should be indicated as backward incompatible, and deleted).

This comment has been minimized.

@sbidoul

sbidoul Feb 10, 2016

Contributor

@xavfernandez ok, I restored the call. All green now.

@sbidoul

sbidoul Feb 10, 2016

Contributor

@xavfernandez ok, I restored the call. All green now.

This comment has been minimized.

@xavfernandez

xavfernandez Feb 10, 2016

Contributor

👍

@xavfernandez

xavfernandez Feb 10, 2016

Contributor

👍

@xavfernandez

This comment has been minimized.

Show comment
Hide comment
@xavfernandez

xavfernandez Feb 9, 2016

Contributor

Yes the pypy failure was due to some flakiness on PyPI apparently.

Contributor

xavfernandez commented Feb 9, 2016

Yes the pypy failure was due to some flakiness on PyPI apparently.

xavfernandez added a commit that referenced this pull request Feb 10, 2016

Merge pull request #3466 from sbidoul/impl-3217-sbi
Allow installing modules from a vcs subdirectory in non-editable mode

@xavfernandez xavfernandez merged commit 496b7c1 into pypa:develop Feb 10, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xavfernandez

This comment has been minimized.

Show comment
Hide comment
@xavfernandez

xavfernandez Feb 10, 2016

Contributor

Thanks a lot !

Contributor

xavfernandez commented Feb 10, 2016

Thanks a lot !

@sbidoul sbidoul deleted the sbidoul:impl-3217-sbi branch Feb 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment