New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix req file encoding detection #3547

Merged
merged 4 commits into from Mar 17, 2016

Conversation

Projects
None yet
6 participants
@xavfernandez
Contributor

xavfernandez commented Mar 7, 2016

Review on Reviewable

@xavfernandez xavfernandez changed the title from Fix bom detection to Fix req file encoding detection Mar 7, 2016

Show outdated Hide outdated pip/utils/encoding.py

dstufft added a commit that referenced this pull request Mar 17, 2016

@dstufft dstufft merged commit 3551d14 into pypa:develop Mar 17, 2016

1 of 2 checks passed

code-review/reviewable Review in progress: 0 of 4 files reviewed, 1 unresolved discussion
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@xavfernandez xavfernandez deleted the xavfernandez:fix_bom_detection branch Apr 3, 2016

@@ -209,6 +210,9 @@ def main(args=None):
sys.stderr.write(os.linesep)
sys.exit(1)
# Needed for locale.getpreferredencoding(False) to work
# in pip.utils.encoding.auto_decode
locale.setlocale(locale.LC_ALL, '')

This comment has been minimized.

@svetlyak40wt

svetlyak40wt May 22, 2016

Some tools, which use pip's python API, fails too. May be it is better to call getpreferredencoding(True)?

@svetlyak40wt

svetlyak40wt May 22, 2016

Some tools, which use pip's python API, fails too. May be it is better to call getpreferredencoding(True)?

@rameez03online

This comment has been minimized.

Show comment
Hide comment
@rameez03online

rameez03online Dec 11, 2017

Hai gurus, I am trying to install a python2 package ising pip2 and I am getting error like this,
File "dendropy/utility/textprocessing.py", line 57, in bytes_to_text
s = codecs.decode(s, ENCODING)
LookupError: unknown encoding: in

----------------------------------------

Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-l4vgA9/dendropy/
After some search I reached this thread
Do anyone knows what to do with this?

rameez03online commented Dec 11, 2017

Hai gurus, I am trying to install a python2 package ising pip2 and I am getting error like this,
File "dendropy/utility/textprocessing.py", line 57, in bytes_to_text
s = codecs.decode(s, ENCODING)
LookupError: unknown encoding: in

----------------------------------------

Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-l4vgA9/dendropy/
After some search I reached this thread
Do anyone knows what to do with this?

@di

This comment has been minimized.

Show comment
Hide comment
@di

di Dec 11, 2017

Member

@rameez03online Your issue is with the DendroPy module, not with pip. You should raise it on their issue tracker here instead.

Member

di commented Dec 11, 2017

@rameez03online Your issue is with the DendroPy module, not with pip. You should raise it on their issue tracker here instead.

@rameez03online

This comment has been minimized.

Show comment
Hide comment
@rameez03online

rameez03online Dec 11, 2017

Thank you @di ... It helped me

rameez03online commented Dec 11, 2017

Thank you @di ... It helped me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment