New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #3682 : pip install --target ignores platlib directories #3694

Merged
merged 1 commit into from May 26, 2016

Conversation

Projects
None yet
4 participants
@chandu-atina
Contributor

chandu-atina commented May 19, 2016

This was migrated from pypa/pip#3684 to reparent it to the master branch. Please see original pull request for any previous discussion.

@chandu-atina

This comment has been minimized.

Show comment
Hide comment
@chandu-atina

chandu-atina May 20, 2016

Contributor

@dstufft @pfmoore Any feedback on this PR will be much appreciated

Contributor

chandu-atina commented May 20, 2016

@dstufft @pfmoore Any feedback on this PR will be much appreciated

@webmaven

This comment has been minimized.

Show comment
Hide comment
@webmaven

webmaven commented May 22, 2016

👍

@kellerza

This comment has been minimized.

Show comment
Hide comment
@kellerza

kellerza May 23, 2016

@chandu-atina I think I am getting a similar result with eventlet that does not install dependency greenlet if --target is specified. Without --target it works fine

$ pip install eventlet --target .
Collecting eventlet
  Using cached eventlet-0.19.0-py2.py3-none-any.whl
Collecting greenlet>=0.3 (from eventlet)
Installing collected packages: greenlet, eventlet
Successfully installed eventlet greenlet

$ ls
eventlet  eventlet-0.19.0.dist-info

CentOS Linux release 7.2.1511 (Core) x64

kellerza commented May 23, 2016

@chandu-atina I think I am getting a similar result with eventlet that does not install dependency greenlet if --target is specified. Without --target it works fine

$ pip install eventlet --target .
Collecting eventlet
  Using cached eventlet-0.19.0-py2.py3-none-any.whl
Collecting greenlet>=0.3 (from eventlet)
Installing collected packages: greenlet, eventlet
Successfully installed eventlet greenlet

$ ls
eventlet  eventlet-0.19.0.dist-info

CentOS Linux release 7.2.1511 (Core) x64

@chandu-atina

This comment has been minimized.

Show comment
Hide comment
@chandu-atina

chandu-atina May 24, 2016

Contributor

@kellerza That is correct, greenlet goes into platlib directory. This PR will handle the issue.
You can apply this fix in your machine and get a try.

Waiting for @dstufft @pfmoore to commment on this.

Contributor

chandu-atina commented May 24, 2016

@kellerza That is correct, greenlet goes into platlib directory. This PR will handle the issue.
You can apply this fix in your machine and get a try.

Waiting for @dstufft @pfmoore to commment on this.

@dstufft dstufft merged commit b15c7f6 into pypa:master May 26, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kellerza

This comment has been minimized.

Show comment
Hide comment
@kellerza

kellerza May 27, 2016

Thank you @chandu-atina I tested it with eventlet and it worked perfectly. Glad to see it was merged as well!

kellerza commented May 27, 2016

Thank you @chandu-atina I tested it with eventlet and it worked perfectly. Glad to see it was merged as well!

waisbrot pushed a commit to waisbrot/pip that referenced this pull request Jul 5, 2016

@wm75 wm75 referenced this pull request Aug 8, 2016

Closed

pip install --target fails #3056

OddBloke added a commit to OddBloke/home-assistant-ansible that referenced this pull request Mar 29, 2017

Upgrade pip on Fedora systems using pip
The pip installed by Fedora can't handle installing in to targets due to
pypa/pip#3694.  This works around that by
installing a pip that can.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment