New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow creating wheels for editable packages #3695

Merged
merged 1 commit into from May 26, 2016

Conversation

Projects
None yet
2 participants
@sbidoul
Contributor

sbidoul commented May 19, 2016

Fixes #3291

This lifts the restriction of not generating wheels for editable packages.

As explained in #3291 and #3379, there are legitimate scenarios for this, such as building wheels from frozen requirements.


This was migrated from pypa/pip#3379 to reparent it to the master branch. Please see original pull request for any previous discussion.

@sbidoul

This comment has been minimized.

Show comment
Hide comment
@sbidoul

sbidoul May 22, 2016

Contributor

I updated the PR with a test and a changelog update, plus a fix to make src_dir absolute as in pip install and pip download.

I hope this can be merged.

As an additional argument in favor of this, I noticed that pip wheel builds editable dependencies (there is even a test for that). Therefore I can't see a good reason for not building editable requirements.

Contributor

sbidoul commented May 22, 2016

I updated the PR with a test and a changelog update, plus a fix to make src_dir absolute as in pip install and pip download.

I hope this can be merged.

As an additional argument in favor of this, I noticed that pip wheel builds editable dependencies (there is even a test for that). Therefore I can't see a good reason for not building editable requirements.

@dstufft dstufft merged commit 4d1b798 into pypa:master May 26, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sbidoul

This comment has been minimized.

Show comment
Hide comment
@sbidoul

sbidoul May 26, 2016

Contributor

Thanks!

Contributor

sbidoul commented May 26, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment