New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pl.pip install additional options #3760

Merged
merged 8 commits into from Aug 12, 2016

Conversation

Projects
None yet
6 participants
@patricklaw
Contributor

patricklaw commented May 27, 2016

This is a continuation of #3092

@patricklaw

This comment has been minimized.

Show comment
Hide comment
@patricklaw

patricklaw Jun 2, 2016

Contributor

@xavfernandez @dstufft Is there anything blocking this PR from being merged? It's been languishing in what I consider a "ready" state for at least a month now, accumulated multiple merge conflicts, and even been auto-closed. What exactly is the process for getting this upstream?

Contributor

patricklaw commented Jun 2, 2016

@xavfernandez @dstufft Is there anything blocking this PR from being merged? It's been languishing in what I consider a "ready" state for at least a month now, accumulated multiple merge conflicts, and even been auto-closed. What exactly is the process for getting this upstream?

Show outdated Hide outdated pip/index.py
@xavfernandez

This comment has been minimized.

Show comment
Hide comment
@xavfernandez

xavfernandez Jun 5, 2016

Contributor

@patricklaw There is no process :)

I personnally like it, but I'd rather have other pip dev take a look at it before it is merged cc (@dstufft @pfmoore ?)

Contributor

xavfernandez commented Jun 5, 2016

@patricklaw There is no process :)

I personnally like it, but I'd rather have other pip dev take a look at it before it is merged cc (@dstufft @pfmoore ?)

@patricklaw

This comment has been minimized.

Show comment
Hide comment
@patricklaw

patricklaw Jun 5, 2016

Contributor

Thanks for the feedback @xavfernandez, pushed fixes

Contributor

patricklaw commented Jun 5, 2016

Thanks for the feedback @xavfernandez, pushed fixes

@pfmoore

This comment has been minimized.

Show comment
Hide comment
@pfmoore

pfmoore Jun 5, 2016

Member

I'm OK with this. I haven't had time to do more than scan the code, but there don't seem to be any glaring issues, and @xavfernandez has done a full review, so I'm +1 on this going in.

Member

pfmoore commented Jun 5, 2016

I'm OK with this. I haven't had time to do more than scan the code, but there don't seem to be any glaring issues, and @xavfernandez has done a full review, so I'm +1 on this going in.

@patricklaw

This comment has been minimized.

Show comment
Hide comment
@patricklaw

patricklaw Jun 17, 2016

Contributor

@xavfernandez is @pfmoore's sign-off sufficient to merge now? It sounds like this is ready to land, and I'd like to avoid more merge conflicts (not to mention consume the change!)

Contributor

patricklaw commented Jun 17, 2016

@xavfernandez is @pfmoore's sign-off sufficient to merge now? It sounds like this is ready to land, and I'd like to avoid more merge conflicts (not to mention consume the change!)

@kwlzn

This comment has been minimized.

Show comment
Hide comment
@kwlzn

kwlzn Jun 25, 2016

pinging on this since it seems to have gone stale - would love to see this land.

kwlzn commented Jun 25, 2016

pinging on this since it seems to have gone stale - would love to see this land.

@sigmavirus24

This comment has been minimized.

Show comment
Hide comment
@sigmavirus24

sigmavirus24 Jul 20, 2016

Member

Probably don't need to worry about the doc nits that I pointed out

Member

sigmavirus24 commented Jul 20, 2016

Probably don't need to worry about the doc nits that I pointed out

@xavfernandez xavfernandez added this to the 8.2 milestone Jul 21, 2016

@xavfernandez

This comment has been minimized.

Show comment
Hide comment
@xavfernandez

xavfernandez Jul 21, 2016

Contributor

@patricklaw except some space nitpicking this seems ready to go in pip 8.2 👍

Contributor

xavfernandez commented Jul 21, 2016

@patricklaw except some space nitpicking this seems ready to go in pip 8.2 👍

Mathew Jennings and others added some commits Jun 15, 2015

Mathew Jennings Patrick Lawson
Add --platform and --python-version to `pip download`.
With the --platform option, a user can download wheels with
a different platform than that of the local machine running the command.

With the --python-version option, a user can
download wheels that are explicitly compatible with a specific
Python interpreter version.

This functionality is meant for utilities that gather dependencies
and prepare distributions for other platforms.
Patrick Lawson
Add --implementation and --abi parameters to ``pip download``.
Add thorough tests, usage documentation, and handle some merge issues.
@asottile

This comment has been minimized.

Show comment
Hide comment
@asottile

asottile Aug 6, 2016

Contributor

It would be cool to add these to install and wheel too. Would potentially deprecate some of the work I've done in https://github.com/asottile/pip-custom-platform

Contributor

asottile commented Aug 6, 2016

It would be cool to add these to install and wheel too. Would potentially deprecate some of the work I've done in https://github.com/asottile/pip-custom-platform

@xavfernandez xavfernandez merged commit 5bd3367 into pypa:master Aug 12, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xavfernandez

This comment has been minimized.

Show comment
Hide comment
@xavfernandez

xavfernandez Aug 12, 2016

Contributor

@patricklaw Thanks a lot :)

Contributor

xavfernandez commented Aug 12, 2016

@patricklaw Thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment