New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use git fetch --tags #3791

Merged
merged 1 commit into from Oct 3, 2016

Conversation

Projects
None yet
2 participants
@sbidoul
Contributor

sbidoul commented Jun 10, 2016

to fetch tags in addition to everything else that
is normally fetched; this is necessary in case a git requirement url
points to a tag or commit that is not on a branch

@sbidoul

This comment has been minimized.

Show comment
Hide comment
@sbidoul

sbidoul Jun 10, 2016

Contributor

Travis is red, but this does not seem related to this PR.

Contributor

sbidoul commented Jun 10, 2016

Travis is red, but this does not seem related to this PR.

@sbidoul

This comment has been minimized.

Show comment
Hide comment
@sbidoul

sbidoul Jun 11, 2016

Contributor

After restarting the build I now have a real error.

Apparently, this particular test fails only with old git versions:

  • git version 1.7.9.5: fails (ubuntu 12.04)
  • git version 1.8.5.6 fails (travis)
  • git version 1.9.1 succeeds (ubuntu 14.04)
  • git version 2.8.4 succeeds
Contributor

sbidoul commented Jun 11, 2016

After restarting the build I now have a real error.

Apparently, this particular test fails only with old git versions:

  • git version 1.7.9.5: fails (ubuntu 12.04)
  • git version 1.8.5.6 fails (travis)
  • git version 1.9.1 succeeds (ubuntu 14.04)
  • git version 2.8.4 succeeds
@xavfernandez

This comment has been minimized.

Show comment
Hide comment
@xavfernandez

xavfernandez Jul 5, 2016

Contributor

In 1.9.0:

The meanings of the "--tags" option to "git fetch" has changed; the
command fetches tags _in addition to_ what is fetched by the same
command line without the option.

So maybe we should call: self.run_command(['fetch', '-q'], cwd=dest) then self.run_command(['fetch', '-q', '--tags'], cwd=dest) to work on previous git version.

We could also first get git version on first git invocation and adapt the behavior according to that.

Contributor

xavfernandez commented Jul 5, 2016

In 1.9.0:

The meanings of the "--tags" option to "git fetch" has changed; the
command fetches tags _in addition to_ what is fetched by the same
command line without the option.

So maybe we should call: self.run_command(['fetch', '-q'], cwd=dest) then self.run_command(['fetch', '-q', '--tags'], cwd=dest) to work on previous git version.

We could also first get git version on first git invocation and adapt the behavior according to that.

@xavfernandez xavfernandez added this to the 8.2 milestone Jul 5, 2016

@xavfernandez

This comment has been minimized.

Show comment
Hide comment
@xavfernandez

xavfernandez Aug 12, 2016

Contributor

@sbidoul : any chance you could fix it ?

Contributor

xavfernandez commented Aug 12, 2016

@sbidoul : any chance you could fix it ?

@sbidoul

This comment has been minimized.

Show comment
Hide comment
@sbidoul

sbidoul Aug 12, 2016

Contributor

@xavfernandez I'll try to look at it again in the coming days/weeks.

Contributor

sbidoul commented Aug 12, 2016

@xavfernandez I'll try to look at it again in the coming days/weeks.

@sbidoul

This comment has been minimized.

Show comment
Hide comment
@sbidoul

sbidoul Aug 13, 2016

Contributor

@xavfernandez here you go. Now using --tags for git >= 1.9.0 only. Rebased.

Contributor

sbidoul commented Aug 13, 2016

@xavfernandez here you go. Now using --tags for git >= 1.9.0 only. Rebased.

@sbidoul

This comment has been minimized.

Show comment
Hide comment
@sbidoul

sbidoul Sep 8, 2016

Contributor

@xavfernandez does it look good?

Contributor

sbidoul commented Sep 8, 2016

@xavfernandez does it look good?

@sbidoul

This comment has been minimized.

Show comment
Hide comment
@sbidoul

sbidoul Sep 10, 2016

Contributor

The appveyor issue in the previous build was real. Now appveyor is green, but travis is red on python nightly, but that is really unrelated to this PR.

Contributor

sbidoul commented Sep 10, 2016

The appveyor issue in the previous build was real. Now appveyor is green, but travis is red on python nightly, but that is really unrelated to this PR.

@xavfernandez

This comment has been minimized.

Show comment
Hide comment
@xavfernandez

xavfernandez Oct 3, 2016

Contributor

@sbidoul This looks fine, could you rebase it on master ?
Sorry I did not respond earlier, I was in holidays for a month and have not found the time to catch on all the pip issues/PR yet.

Contributor

xavfernandez commented Oct 3, 2016

@sbidoul This looks fine, could you rebase it on master ?
Sorry I did not respond earlier, I was in holidays for a month and have not found the time to catch on all the pip issues/PR yet.

use git fetch --tags
to fetch tags in addition to everything else that
is normally fetched; this is necessary in case a git requirement url
points to a tag or commit that is not on a branch
@sbidoul

This comment has been minimized.

Show comment
Hide comment
@sbidoul

sbidoul Oct 3, 2016

Contributor

@xavfernandez Here you go. No problem for the delay, appreciate the work you all do here! Looking forward to 8.2.

Contributor

sbidoul commented Oct 3, 2016

@xavfernandez Here you go. No problem for the delay, appreciate the work you all do here! Looking forward to 8.2.

@xavfernandez xavfernandez merged commit 4c4df97 into pypa:master Oct 3, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xavfernandez

This comment has been minimized.

Show comment
Hide comment
@xavfernandez

xavfernandez Oct 3, 2016

Contributor

Thanks 👍

Contributor

xavfernandez commented Oct 3, 2016

Thanks 👍

@sbidoul sbidoul deleted the sbidoul:8.0-git-fetch-sbi branch Oct 23, 2016

@sbidoul sbidoul restored the sbidoul:8.0-git-fetch-sbi branch Oct 23, 2016

@sbidoul sbidoul deleted the sbidoul:8.0-git-fetch-sbi branch Oct 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment