New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort install if Requires-Python do not match the running version #3846

Merged
merged 5 commits into from Oct 27, 2016

Conversation

Projects
None yet
6 participants
@xavfernandez
Contributor

xavfernandez commented Jul 14, 2016

Once pypa/setuptools#631 is merged, it should be easier to add functionnal tests

I'm wondering wheither pip should provide an escape hatch via some --ignore-requires-python or not.

@dholth

This comment has been minimized.

Show comment
Hide comment
@dholth

dholth Jul 14, 2016

Member

Yes, it should have an escape hatch.

Member

dholth commented Jul 14, 2016

Yes, it should have an escape hatch.

@xavfernandez

This comment has been minimized.

Show comment
Hide comment
@xavfernandez

xavfernandez Jul 17, 2016

Contributor

Escape hatch added.

This PR would also help avoid further issues like #3390

Contributor

xavfernandez commented Jul 17, 2016

Escape hatch added.

This PR would also help avoid further issues like #3390

Show outdated Hide outdated pip/utils/packaging.py
@sigmavirus24

This comment has been minimized.

Show comment
Hide comment
@sigmavirus24

sigmavirus24 Aug 12, 2016

Member

This is exciting!

Member

sigmavirus24 commented Aug 12, 2016

This is exciting!

@xavfernandez

This comment has been minimized.

Show comment
Hide comment
@xavfernandez

xavfernandez Oct 11, 2016

Contributor

@pfmoore @dstufft does this look ok to you ?

Contributor

xavfernandez commented Oct 11, 2016

@pfmoore @dstufft does this look ok to you ?

Show outdated Hide outdated pip/exceptions.py
@pfmoore

This comment has been minimized.

Show comment
Hide comment
@pfmoore

pfmoore Oct 11, 2016

Member

Other than the one minor comment, LGTM.

Member

pfmoore commented Oct 11, 2016

Other than the one minor comment, LGTM.

@xavfernandez xavfernandez merged commit 8df742e into pypa:master Oct 27, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@xavfernandez xavfernandez deleted the xavfernandez:check_python_requires branch Oct 27, 2016

@piotr-dobrogost

This comment has been minimized.

Show comment
Hide comment
@piotr-dobrogost

piotr-dobrogost Oct 28, 2016

@xavfernandez
Thanks for this!
I added it as a solution to the old standing question How to write Python code that is able to properly require a minimal python version? at SO.

piotr-dobrogost commented Oct 28, 2016

@xavfernandez
Thanks for this!
I added it as a solution to the old standing question How to write Python code that is able to properly require a minimal python version? at SO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment