New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pip when using Py2 on Windows with non-ASCII hostname or username (originally #3970 from @pekkaklarck) #4000

Merged
merged 4 commits into from Oct 6, 2016

Conversation

Projects
None yet
3 participants
@pfmoore
Member

pfmoore commented Oct 5, 2016

No description provided.

@pekkaklarck

This comment has been minimized.

Show comment
Hide comment
@pekkaklarck

pekkaklarck Oct 6, 2016

Contributor

Looks good to me! CHANGES.txt still refers to the original PR #3970 and not this one, though.

Contributor

pekkaklarck commented Oct 6, 2016

Looks good to me! CHANGES.txt still refers to the original PR #3970 and not this one, though.

@pfmoore

This comment has been minimized.

Show comment
Hide comment
@pfmoore

pfmoore Oct 6, 2016

Member

@pekkaklarck Cool, thanks. I've added this PR to the changelog (left yours as well, for reference) and when the tests complete I'll push this.

Thanks for providing this fix!

Member

pfmoore commented Oct 6, 2016

@pekkaklarck Cool, thanks. I've added this PR to the changelog (left yours as well, for reference) and when the tests complete I'll push this.

Thanks for providing this fix!

@pfmoore pfmoore merged commit fc103a7 into pypa:master Oct 6, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xavfernandez

This comment has been minimized.

Show comment
Hide comment
@xavfernandez

xavfernandez Oct 6, 2016

Contributor

@pfmoore @pekkaklarck Thanks for dealing with this :)

Contributor

xavfernandez commented Oct 6, 2016

@pfmoore @pekkaklarck Thanks for dealing with this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment