Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for wheel build tags #4299

Merged
merged 2 commits into from Aug 31, 2017
Merged

Add support for wheel build tags #4299

merged 2 commits into from Aug 31, 2017

Conversation

sigmavirus24
Copy link
Member

@sigmavirus24 sigmavirus24 commented Feb 22, 2017 •
edited by dstufft

At the moment, pip doesn't support ordering candidate installations
while considering build tags. This is meant to start adding that
support.

This change is Reviewable

@dstufft
Copy link
Member

dstufft commented Feb 22, 2017

This looks reasonable good thus far!

@sigmavirus24
Copy link
Member Author

So, @dstufft how would I go about testing this?

@dstufft
Copy link
Member

dstufft commented Mar 5, 2017

@sigmavirus24 sorry for the delay. You'd probably do something similar to what you already see in tests/unit/test_finder.py. These are basically tests that setup a fake PyPI on the local FS and point the finder at that.

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Apr 1, 2017
@pradyunsg
Copy link
Member

Hi @sigmavirus24!

Is this still relevant? Are you still interested in taking this forward?

@sigmavirus24
Copy link
Member Author

I am. I just lost track of it. Thanks for the ping @pradyunsg!

@pradyunsg pradyunsg added type: enhancement Improvements to functionality C: wheel The wheel format and 'pip wheel' command labels Aug 21, 2017
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Aug 22, 2017
@sigmavirus24 sigmavirus24 changed the title WIP: Add support for wheel build tags Add support for wheel build tags Aug 22, 2017
@sigmavirus24
Copy link
Member Author

This has been rebased with tests. 🍰

@sigmavirus24
Add support for wheel build tags
f6b56e5 
At the moment, pip doesn't support ordering candidate installations
while considering build tags. This is meant to start adding that
support.

According to the PEP, the first contiguous set of integers in the build
tag should be sorted numerically. After that, they should be sorted
alphabetically.
@sigmavirus24
Add news entry for PR 4299
5749dd1
@dstufft dstufft merged commit 283cf2c into pypa:master Aug 31, 2017
@sigmavirus24 sigmavirus24 deleted the wheel-build-tags branch August 31, 2017 11:58
@pradyunsg pradyunsg added this to the 10.0 milestone Oct 2, 2017
@xavfernandez xavfernandez mentioned this pull request Oct 11, 2017
Closed
This was referenced Apr 12, 2018
Closed
Open
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: wheel The wheel format and 'pip wheel' command type: enhancement Improvements to functionality
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sigmavirus24 @dstufft @BrownTruck @pradyunsg @pypa-bot