New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only warn for mis-versioned packages. #436

Merged
merged 1 commit into from Sep 1, 2012

Conversation

Projects
None yet
6 participants
@kennethreitz
Contributor

kennethreitz commented Jan 19, 2012

Allows Package==dev in requirements.

Prevents this:

Now this happens:

🍰

Only warn for mis-versioned packages.
Allows Package==dev in requirements.
@carljm

This comment has been minimized.

Show comment
Hide comment
@carljm

carljm Jan 19, 2012

Contributor

Thanks! Any chance of getting a test for this? Shouldn't be hard to do with a simple built-in package in the bundled test package index, see the upgrade tests for one existing test that uses this.

Contributor

carljm commented Jan 19, 2012

Thanks! Any chance of getting a test for this? Shouldn't be hard to do with a simple built-in package in the bundled test package index, see the upgrade tests for one existing test that uses this.

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz

kennethreitz Jan 25, 2012

Contributor

Tests will be added shortly.

Contributor

kennethreitz commented Jan 25, 2012

Tests will be added shortly.

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz

kennethreitz Feb 6, 2012

Contributor

Maybe.

Contributor

kennethreitz commented Feb 6, 2012

Maybe.

@pnasrat

This comment has been minimized.

Show comment
Hide comment
@pnasrat

pnasrat May 13, 2012

Contributor

@kennethreitz is that still a maybe for the tests? If you don't have time I can probably write them on top of your commit.

Contributor

pnasrat commented May 13, 2012

@kennethreitz is that still a maybe for the tests? If you don't have time I can probably write them on top of your commit.

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz

kennethreitz May 13, 2012

Contributor

@pnasrat I hope to get around to it soon, but by all means feel free to if you'd like :)

Contributor

kennethreitz commented May 13, 2012

@pnasrat I hope to get around to it soon, but by all means feel free to if you'd like :)

@rdegges

This comment has been minimized.

Show comment
Hide comment
@rdegges

rdegges Jul 13, 2012

+1000 for this. <3 @kennethreitz

rdegges commented Jul 13, 2012

+1000 for this. <3 @kennethreitz

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz

kennethreitz Jul 13, 2012

Contributor

(reopened for travis-ci)

Contributor

kennethreitz commented Jul 13, 2012

(reopened for travis-ci)

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Jul 14, 2012

This pull request passes (merged 15bf408 into 1445ff6).

travisbot commented Jul 14, 2012

This pull request passes (merged 15bf408 into 1445ff6).

jezdez added a commit that referenced this pull request Sep 1, 2012

Merge pull request #436 from kennethreitz/feature/eqdev
Only warn for mis-versioned packages.

@jezdez jezdez merged commit ad254bc into pypa:develop Sep 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment