Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Preserve the query portion of URL-type InstallRequirement URLs. #504
With this patch, install commands like:
pip install 'http://foo.com/?p=bar.git;a=snapshot;h=v0.3;sf=tgz'
will work as expected.
The naming scheme for Link properties is a bit confused at the moment, and I haven't done anything about that here. Link.url_fragment should probably renamed. Perhaps Link.url_without_query_or_fragment. If you don't mind sacrificing a bit of accuracy, Link.url_path would also work, especially since Link.url_fragment is currently only being used in Link.filename.
The test suite passes, with following exceptions:
which both had the same results before my commit (i.e. as of dfe39ed).
What kind of test did you have in mind for my patch? I think testing would require a package that serves it's download over HTTP. This seems like a lot of infrastructure to set up inside the test suite...