Add split_auth_from_netloc() to misc.py #5657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjerdonek
force-pushed
the
misc-add-split-auth-from-url
branch
from
fe7600d
to
58b21d1
Compare
pradyunsg
approved these changes
Jul 26, 2018
|
Thanks a lot for reviewing. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the implementation of
Subversion.get_netloc_and_auth()tomisc.py. A couple of benefits of this are--It lets us ensure that
remove_auth_from_url()andSubversion.get_netloc_and_auth()both use the same logic for splitting the auth information from the netloc (in particular splitting along the rightmost "@"), and it lets us centralize the tests.This also sets up PR Redact password from various log messages #5590 to be implemented with less code duplication, since some of the needed logic is already implemented by
Subversion.get_netloc_and_auth().