Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the ascii progress bar really be ascii, not Unicode #5671

Merged
merged 2 commits into from Jul 6, 2019

Conversation

@segevfiner
Copy link
Contributor

commented Jul 29, 2018

Found while debugging #5665 (Not a fix for that issue)

segevfiner added some commits Jul 29, 2018

@pradyunsg
Copy link
Member

left a comment

Love how the NEWS fragment reads. ^.^

@pradyunsg pradyunsg requested a review from pfmoore Nov 9, 2018

@pradyunsg

This comment has been minimized.

Copy link
Member

commented Nov 9, 2018

For easier reference, the links to GitHub source code of the changed base classes:

Bar: https://github.com/verigak/progress/blob/1.4/progress/bar.py#L25
IncrementalBar: https://github.com/verigak/progress/blob/1.4/progress/bar.py#L66

@pradyunsg pradyunsg merged commit d4f0f4e into pypa:master Jul 6, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
news-file/pr News files updated and/or change is trivial.
Details
@pradyunsg

This comment has been minimized.

Copy link
Member

commented Jul 6, 2019

Thanks for this @segevfiner! :)

@segevfiner segevfiner deleted the segevfiner:ascii-progress-bar-fix branch Jul 6, 2019

@lock lock bot added the S: auto-locked label Aug 5, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.