Test call_subprocess more thoroughly; fix spinner edge cases #6312
+240
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to test
call_subprocess()
more thoroughly for a subsequent PR.However, in the process I noticed a couple edge cases with the spinner that this PR fixes. They are--
The spinner says
error
if the return code was non-zero but was one of the passedextra_ok_returncodes
(and so should be acceptable). The spinner should instead saydone
.The spinner reports a final
done
/error
finishing message even if the spinner wasn't actually used (e.g. in the case thatshow_stdout
was true).Both of these fixes can be seen in the changes in the test expectation in the second commit of this PR.