Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test call_subprocess more thoroughly; fix spinner edge cases #6312

Merged
merged 2 commits into from Mar 12, 2019

Conversation

Projects
None yet
2 participants
@cjerdonek
Copy link
Member

commented Mar 3, 2019

The main purpose of this PR is to test call_subprocess() more thoroughly for a subsequent PR.

However, in the process I noticed a couple edge cases with the spinner that this PR fixes. They are--

  1. The spinner says error if the return code was non-zero but was one of the passed extra_ok_returncodes (and so should be acceptable). The spinner should instead say done.

  2. The spinner reports a final done / error finishing message even if the spinner wasn't actually used (e.g. in the case that show_stdout was true).

Both of these fixes can be seen in the changes in the test expectation in the second commit of this PR.

@cjerdonek cjerdonek force-pushed the cjerdonek:subprocess-tests-and-spinner-fixes branch from f5b9256 to cd5984d Mar 3, 2019

@cjerdonek cjerdonek force-pushed the cjerdonek:subprocess-tests-and-spinner-fixes branch 3 times, most recently from 6edb20b to c7f8a2b Mar 3, 2019

@cjerdonek cjerdonek force-pushed the cjerdonek:subprocess-tests-and-spinner-fixes branch from c7f8a2b to 9a4967b Mar 3, 2019

@cjerdonek cjerdonek force-pushed the cjerdonek:subprocess-tests-and-spinner-fixes branch from 9a4967b to fe79372 Mar 3, 2019

@cjerdonek

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2019

@pradyunsg Would you be able to take a look at this PR? It mostly consists of adding tests (the first commit), but it also fixes a couple spinner edge cases (the second commit).

@pradyunsg

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

Yep.

@pradyunsg
Copy link
Member

left a comment

I'm okay with these changes.

@cjerdonek

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2019

Thanks, @pradyunsg.

@cjerdonek cjerdonek merged commit 1599d65 into pypa:master Mar 12, 2019

29 checks passed

Linux Build #20190303.12 succeeded
Details
Linux (Package) Package succeeded
Details
Linux (Test Primary Python27) Test Primary Python27 succeeded
Details
Linux (Test Primary Python36) Test Primary Python36 succeeded
Details
Linux (Test Secondary Python34) Test Secondary Python34 succeeded
Details
Linux (Test Secondary Python35) Test Secondary Python35 succeeded
Details
Linux (Test Secondary Python37) Test Secondary Python37 succeeded
Details
Windows Build #20190303.12 succeeded
Details
Windows (Package) Package succeeded
Details
Windows (Test Primary Python27-x64) Test Primary Python27-x64 succeeded
Details
Windows (Test Primary Python36-x64) Test Primary Python36-x64 succeeded
Details
Windows (Test Secondary Python27-x86) Test Secondary Python27-x86 succeeded
Details
Windows (Test Secondary Python34-x64) Test Secondary Python34-x64 succeeded
Details
Windows (Test Secondary Python34-x86) Test Secondary Python34-x86 succeeded
Details
Windows (Test Secondary Python35-x64) Test Secondary Python35-x64 succeeded
Details
Windows (Test Secondary Python35-x86) Test Secondary Python35-x86 succeeded
Details
Windows (Test Secondary Python36-x86) Test Secondary Python36-x86 succeeded
Details
Windows (Test Secondary Python37-x64) Test Secondary Python37-x64 succeeded
Details
Windows (Test Secondary Python37-x86) Test Secondary Python37-x86 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
macOS Build #20190303.12 succeeded
Details
macOS (Package) Package succeeded
Details
macOS (Test Primary Python27) Test Primary Python27 succeeded
Details
macOS (Test Primary Python36) Test Primary Python36 succeeded
Details
macOS (Test Secondary Python34) Test Secondary Python34 succeeded
Details
macOS (Test Secondary Python35) Test Secondary Python35 succeeded
Details
macOS (Test Secondary Python37) Test Secondary Python37 succeeded
Details
news-file/pr News files updated and/or change is trivial.
Details

@cjerdonek cjerdonek deleted the cjerdonek:subprocess-tests-and-spinner-fixes branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.