Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update progress to 1.5 #6319

Merged
merged 3 commits into from Apr 23, 2019
Merged

Update progress to 1.5 #6319

merged 3 commits into from Apr 23, 2019

Conversation

@pquentin
Copy link
Contributor

@pquentin pquentin commented Mar 7, 2019

This progress release contains verigak/progress#61, a PR that I submitted hoping that it would end up in pip: the ETA and average speed are no longer updated at every tick, but only once per second.

Indeed, when pip installing large packages with a slow/unreliable connection, the information changed so often as to be unreadable. The estimate is still not really good: progress only considers the last 10 updates, ie. the last ~100kB downloaded by pip. But I think that's a different issue that can be solved in another progress PR.

@eli-schwartz
Copy link
Contributor

@eli-schwartz eli-schwartz commented Mar 7, 2019

I was just about to submit a PR for this myself. :D https://github.com/eli-schwartz/pip/tree/progress-update

You'll need to update src/pip/_internal/utils/ui.py as well, or this simply won't work...

Loading

@pquentin
Copy link
Contributor Author

@pquentin pquentin commented Mar 7, 2019

@eli-schwartz Nice catch, thanks! I used rsync to update the files, but forgot to pass --delete, so I still had helpers.py, which is why it was still working. I added a commit to fix this. We could use your commit too, but I think you need to replace 1.15 with 1.5 first.

Loading

@eli-schwartz
Copy link
Contributor

@eli-schwartz eli-schwartz commented Mar 7, 2019

Replace what? :D

Also, you can use invoke vendoring.update to run the entire vendoring process properly, which would have the same effect without surprising rsync snafus.

Loading

@pquentin
Copy link
Contributor Author

@pquentin pquentin commented Mar 7, 2019

I see what you did there. :)

And thanks for the invoke tip!

Loading

jayvdb
jayvdb approved these changes Mar 26, 2019
@@ -0,0 +1 @@
Update progress to 1.5
Copy link
Member

@cjerdonek cjerdonek Mar 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add a .feature news entry with a description of the changes that pip users will notice.

Loading

Copy link
Contributor Author

@pquentin pquentin Mar 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done in 2ce546e

Loading

@cjerdonek
Copy link
Member

@cjerdonek cjerdonek commented Mar 27, 2019

@pradyunsg Does this look okay to you for updating a vendored library?

Loading

@pquentin
Copy link
Contributor Author

@pquentin pquentin commented Apr 1, 2019

Rebased on top of master to get the CI fixes

Loading

@dstufft dstufft merged commit 627eeec into pypa:master Apr 23, 2019
29 checks passed
Loading
@lock
Copy link

@lock lock bot commented May 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Loading

@lock lock bot added the S: auto-locked label May 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants