Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update progress to 1.5 #6319

Merged
merged 3 commits into from Apr 23, 2019

Conversation

Projects
None yet
5 participants
@pquentin
Copy link
Contributor

commented Mar 7, 2019

This progress release contains verigak/progress#61, a PR that I submitted hoping that it would end up in pip: the ETA and average speed are no longer updated at every tick, but only once per second.

Indeed, when pip installing large packages with a slow/unreliable connection, the information changed so often as to be unreadable. The estimate is still not really good: progress only considers the last 10 updates, ie. the last ~100kB downloaded by pip. But I think that's a different issue that can be solved in another progress PR.

@eli-schwartz

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

I was just about to submit a PR for this myself. :D https://github.com/eli-schwartz/pip/tree/progress-update

You'll need to update src/pip/_internal/utils/ui.py as well, or this simply won't work...

@pquentin

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

@eli-schwartz Nice catch, thanks! I used rsync to update the files, but forgot to pass --delete, so I still had helpers.py, which is why it was still working. I added a commit to fix this. We could use your commit too, but I think you need to replace 1.15 with 1.5 first.

@pquentin pquentin force-pushed the pquentin:progress1.5 branch from 298b985 to 225d77f Mar 7, 2019

@eli-schwartz

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

Replace what? :D

Also, you can use invoke vendoring.update to run the entire vendoring process properly, which would have the same effect without surprising rsync snafus.

@pquentin

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

I see what you did there. :)

And thanks for the invoke tip!

@jayvdb

jayvdb approved these changes Mar 26, 2019

@@ -0,0 +1 @@
Update progress to 1.5

This comment has been minimized.

Copy link
@cjerdonek

cjerdonek Mar 27, 2019

Member

I would also add a .feature news entry with a description of the changes that pip users will notice.

This comment has been minimized.

Copy link
@pquentin

pquentin Mar 28, 2019

Author Contributor

Thanks, done in 2ce546e

@cjerdonek

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

@pradyunsg Does this look okay to you for updating a vendored library?

@pquentin pquentin force-pushed the pquentin:progress1.5 branch from 225d77f to 2ce546e Mar 28, 2019

pquentin added some commits Mar 7, 2019

@pquentin pquentin force-pushed the pquentin:progress1.5 branch from 2ce546e to dbce821 Apr 1, 2019

@pquentin

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

Rebased on top of master to get the CI fixes

@dstufft dstufft merged commit 627eeec into pypa:master Apr 23, 2019

29 checks passed

Linux Build #20190401.2 succeeded
Details
Linux (Package) Package succeeded
Details
Linux (Test Primary Python27) Test Primary Python27 succeeded
Details
Linux (Test Primary Python36) Test Primary Python36 succeeded
Details
Linux (Test Secondary Python34) Test Secondary Python34 succeeded
Details
Linux (Test Secondary Python35) Test Secondary Python35 succeeded
Details
Linux (Test Secondary Python37) Test Secondary Python37 succeeded
Details
Windows Build #20190401.2 succeeded
Details
Windows (Package) Package succeeded
Details
Windows (Test Primary Python27-x64) Test Primary Python27-x64 succeeded
Details
Windows (Test Primary Python36-x64) Test Primary Python36-x64 succeeded
Details
Windows (Test Secondary Python27-x86) Test Secondary Python27-x86 succeeded
Details
Windows (Test Secondary Python34-x64) Test Secondary Python34-x64 succeeded
Details
Windows (Test Secondary Python34-x86) Test Secondary Python34-x86 succeeded
Details
Windows (Test Secondary Python35-x64) Test Secondary Python35-x64 succeeded
Details
Windows (Test Secondary Python35-x86) Test Secondary Python35-x86 succeeded
Details
Windows (Test Secondary Python36-x86) Test Secondary Python36-x86 succeeded
Details
Windows (Test Secondary Python37-x64) Test Secondary Python37-x64 succeeded
Details
Windows (Test Secondary Python37-x86) Test Secondary Python37-x86 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
macOS Build #20190401.2 succeeded
Details
macOS (Package) Package succeeded
Details
macOS (Test Primary Python27) Test Primary Python27 succeeded
Details
macOS (Test Primary Python36) Test Primary Python36 succeeded
Details
macOS (Test Secondary Python34) Test Secondary Python34 succeeded
Details
macOS (Test Secondary Python35) Test Secondary Python35 succeeded
Details
macOS (Test Secondary Python37) Test Secondary Python37 succeeded
Details
news-file/pr News files updated and/or change is trivial.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.