-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update progress to 1.5 #6319
Update progress to 1.5 #6319
Conversation
I was just about to submit a PR for this myself. :D https://github.com/eli-schwartz/pip/tree/progress-update You'll need to update src/pip/_internal/utils/ui.py as well, or this simply won't work... |
@eli-schwartz Nice catch, thanks! I used rsync to update the files, but forgot to pass --delete, so I still had helpers.py, which is why it was still working. I added a commit to fix this. We could use your commit too, but I think you need to replace 1.15 with 1.5 first. |
Replace what? :D Also, you can use |
I see what you did there. :) And thanks for the invoke tip! |
@@ -0,0 +1 @@ | |||
Update progress to 1.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also add a .feature
news entry with a description of the changes that pip users will notice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, done in 2ce546e
@pradyunsg Does this look okay to you for updating a vendored library? |
Rebased on top of master to get the CI fixes |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This progress release contains verigak/progress#61, a PR that I submitted hoping that it would end up in pip: the ETA and average speed are no longer updated at every tick, but only once per second.
Indeed, when pip installing large packages with a slow/unreliable connection, the information changed so often as to be unreadable. The estimate is still not really good: progress only considers the last 10 updates, ie. the last ~100kB downloaded by pip. But I think that's a different issue that can be solved in another progress PR.