Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redact passwords in output when using --find-links #6489

Merged
merged 6 commits into from May 22, 2019

Conversation

@anlutro
Copy link
Contributor

commented May 9, 2019

This is a PR almost identical to #5773 but for --find-links.

@xavfernandez

This comment has been minimized.

Copy link
Contributor

commented May 12, 2019

Thanks for the PR.
A news file and a test would be required though.

@anlutro

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

@xavfernandez modified a test to cover the new behaviour. what type of news entry would this be? I picked trivial but I guess that's not correct. Is this a feature or a bugfix?

@xavfernandez

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

@anlutro like #5773, a bugfix

@pypa-bot

This comment has been minimized.

Copy link

commented May 20, 2019

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

@anlutro anlutro force-pushed the alprs:fix-redact-url-find-links branch from 24ff1a5 to 3e7fa09 May 20, 2019

@anlutro

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

@xavfernandez thanks for the feedback, sorry for the slow responses!

@xavfernandez xavfernandez merged commit 9eccfae into pypa:master May 22, 2019

29 checks passed

Linux Build #20190520.4 succeeded
Details
Linux (Package) Package succeeded
Details
Linux (Test Primary Python27) Test Primary Python27 succeeded
Details
Linux (Test Primary Python36) Test Primary Python36 succeeded
Details
Linux (Test Secondary Python34) Test Secondary Python34 succeeded
Details
Linux (Test Secondary Python35) Test Secondary Python35 succeeded
Details
Linux (Test Secondary Python37) Test Secondary Python37 succeeded
Details
Windows Build #20190520.4 succeeded
Details
Windows (Package) Package succeeded
Details
Windows (Test Primary Python27-x64) Test Primary Python27-x64 succeeded
Details
Windows (Test Primary Python36-x64) Test Primary Python36-x64 succeeded
Details
Windows (Test Secondary Python27-x86) Test Secondary Python27-x86 succeeded
Details
Windows (Test Secondary Python34-x64) Test Secondary Python34-x64 succeeded
Details
Windows (Test Secondary Python34-x86) Test Secondary Python34-x86 succeeded
Details
Windows (Test Secondary Python35-x64) Test Secondary Python35-x64 succeeded
Details
Windows (Test Secondary Python35-x86) Test Secondary Python35-x86 succeeded
Details
Windows (Test Secondary Python36-x86) Test Secondary Python36-x86 succeeded
Details
Windows (Test Secondary Python37-x64) Test Secondary Python37-x64 succeeded
Details
Windows (Test Secondary Python37-x86) Test Secondary Python37-x86 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
macOS Build #20190520.4 succeeded
Details
macOS (Package) Package succeeded
Details
macOS (Test Primary Python27) Test Primary Python27 succeeded
Details
macOS (Test Primary Python36) Test Primary Python36 succeeded
Details
macOS (Test Secondary Python34) Test Secondary Python34 succeeded
Details
macOS (Test Secondary Python35) Test Secondary Python35 succeeded
Details
macOS (Test Secondary Python37) Test Secondary Python37 succeeded
Details
news-file/pr News files updated and/or change is trivial.
Details
@xavfernandez

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

Thanks @anlutro 👍

wilsonfv added a commit to wilsonfv/pip that referenced this pull request Jun 2, 2019

@lock lock bot added the S: auto-locked label Jun 21, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Jun 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.