Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redact passwords in output when using --find-links #6489

Merged
merged 6 commits into from
May 22, 2019
Merged

redact passwords in output when using --find-links #6489

merged 6 commits into from
May 22, 2019

Conversation

anlutro
Copy link
Contributor

@anlutro anlutro commented May 9, 2019

This is a PR almost identical to #5773 but for --find-links.

@xavfernandez
Copy link
Member

Thanks for the PR.
A news file and a test would be required though.

@anlutro
Copy link
Contributor Author

anlutro commented May 14, 2019

@xavfernandez modified a test to cover the new behaviour. what type of news entry would this be? I picked trivial but I guess that's not correct. Is this a feature or a bugfix?

@xavfernandez
Copy link
Member

@anlutro like #5773, a bugfix

@pypa-bot
Copy link

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

@pypa-bot pypa-bot added the needs rebase or merge PR has conflicts with current master label May 20, 2019
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label May 20, 2019
@anlutro
Copy link
Contributor Author

anlutro commented May 20, 2019

@xavfernandez thanks for the feedback, sorry for the slow responses!

@xavfernandez xavfernandez merged commit 9eccfae into pypa:master May 22, 2019
@xavfernandez
Copy link
Member

Thanks @anlutro 👍

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 21, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xavfernandez xavfernandez xavfernandez left review comments

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anlutro @xavfernandez @pypa-bot