Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deprecation warnings #6549

Merged
merged 5 commits into from May 27, 2019
Merged

Conversation

@pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented May 27, 2019

Fixes #6216
Supercedes #6218

@pradyunsg
Copy link
Member Author

@pradyunsg pradyunsg commented May 27, 2019

Thanks for the review @xavfernandez! :D

@pradyunsg
Copy link
Member Author

@pradyunsg pradyunsg commented May 27, 2019

I'll merge this now.

@cjerdonek I hope you don't mind that; I'll be happy to hear suggestions from you on this, if you have any. :)

@pradyunsg pradyunsg merged commit a1ad4b7 into pypa:master May 27, 2019
29 checks passed
@pradyunsg pradyunsg deleted the improve-deprecation-warnings branch May 27, 2019
@cjerdonek
Copy link
Member

@cjerdonek cjerdonek commented May 27, 2019

I'll be happy to hear suggestions from you on this

I made review comments on the original PR you filed. I don't know if you addressed them here or not.

@pradyunsg
Copy link
Member Author

@pradyunsg pradyunsg commented May 27, 2019

I did. :)

Except for the one on the error message changing based on error vs warning, for which I made #6218 (comment).

@lock lock bot added the S: auto-locked label Jun 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants