Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deprecation warnings #6549

Merged
merged 5 commits into from May 27, 2019

Conversation

@pradyunsg
Copy link
Member

commented May 27, 2019

Fixes #6216
Supercedes #6218

pradyunsg added some commits Jan 29, 2019

@pradyunsg pradyunsg force-pushed the pradyunsg:improve-deprecation-warnings branch from b20c8d1 to 2ff13e4 May 27, 2019

@pradyunsg

This comment has been minimized.

Copy link
Member Author

commented May 27, 2019

Thanks for the review @xavfernandez! :D

@pradyunsg

This comment has been minimized.

Copy link
Member Author

commented May 27, 2019

I'll merge this now.

@cjerdonek I hope you don't mind that; I'll be happy to hear suggestions from you on this, if you have any. :)

@pradyunsg pradyunsg merged commit a1ad4b7 into pypa:master May 27, 2019

29 checks passed

Linux Build #20190527.5 succeeded
Details
Linux (Package) Package succeeded
Details
Linux (Test Primary Python27) Test Primary Python27 succeeded
Details
Linux (Test Primary Python36) Test Primary Python36 succeeded
Details
Linux (Test Secondary Python34) Test Secondary Python34 succeeded
Details
Linux (Test Secondary Python35) Test Secondary Python35 succeeded
Details
Linux (Test Secondary Python37) Test Secondary Python37 succeeded
Details
Windows Build #20190527.5 succeeded
Details
Windows (Package) Package succeeded
Details
Windows (Test Primary Python27-x64) Test Primary Python27-x64 succeeded
Details
Windows (Test Primary Python36-x64) Test Primary Python36-x64 succeeded
Details
Windows (Test Secondary Python27-x86) Test Secondary Python27-x86 succeeded
Details
Windows (Test Secondary Python34-x64) Test Secondary Python34-x64 succeeded
Details
Windows (Test Secondary Python34-x86) Test Secondary Python34-x86 succeeded
Details
Windows (Test Secondary Python35-x64) Test Secondary Python35-x64 succeeded
Details
Windows (Test Secondary Python35-x86) Test Secondary Python35-x86 succeeded
Details
Windows (Test Secondary Python36-x86) Test Secondary Python36-x86 succeeded
Details
Windows (Test Secondary Python37-x64) Test Secondary Python37-x64 succeeded
Details
Windows (Test Secondary Python37-x86) Test Secondary Python37-x86 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
macOS Build #20190527.5 succeeded
Details
macOS (Package) Package succeeded
Details
macOS (Test Primary Python27) Test Primary Python27 succeeded
Details
macOS (Test Primary Python36) Test Primary Python36 succeeded
Details
macOS (Test Secondary Python34) Test Secondary Python34 succeeded
Details
macOS (Test Secondary Python35) Test Secondary Python35 succeeded
Details
macOS (Test Secondary Python37) Test Secondary Python37 succeeded
Details
news-file/pr News files updated and/or change is trivial.
Details

@pradyunsg pradyunsg deleted the pradyunsg:improve-deprecation-warnings branch May 27, 2019

@cjerdonek

This comment has been minimized.

Copy link
Member

commented May 27, 2019

I'll be happy to hear suggestions from you on this

I made review comments on the original PR you filed. I don't know if you addressed them here or not.

@pradyunsg

This comment has been minimized.

Copy link
Member Author

commented May 27, 2019

I did. :)

Except for the one on the error message changing based on error vs warning, for which I made #6218 (comment).

@lock lock bot added the S: auto-locked label Jun 26, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Jun 26, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.