Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Drop support for EOL Python 3.4 #6685
Python 3.4 was EOL on 2019-03-16 and deprecated in #6123 and pip 19.0.
The deprecation warning reads:
pip 19.2 is coming soon (#6630) so drop support for Python 3.4.
But if someone does end up with this PR's changes on 3.4, it'll still work as no functional changes have been made.
It may fail with the next PR, and will fail at some point in the future as code is modernised and newer features are used.
Would you like an explicit failure message for unsupported versions (<=2.6, 3.0-3.4)? Although care would have to be taken to make sure the file showing the error is still actually compatible with those versions, and it should be tested to be sure it still works in the long term.
What has been the approach for earlier removals?
No point in doing this IMO.
FWIW, modern versions of pip will refuse to install this version on 3.4 anyway. Once you start modifying the distribution, we're not liable for it.