Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor wheel.move_wheel_files to use updated distlib #6763
With the recent update to distlib, we can rid ourselves of some workarounds in wheel.py.
Now we rely on the script template in distlib here.
The script template is essentially the same as the one that was in wheel.py before, with the exception of the regular expression here. For reference, our original regular expression was
In a followup PR I should be able to extract and unit test the generation of the script spec generation.
I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the
@chrahunt A git-workflow-related comment: It's much easier to review PRs when changes-with-changing-variable-names vs other changes happen in separate commits.
This PR would've been easier to review if there were 2 separate commits: