Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that `--ignore-installed` is dangerous #6794

Merged
merged 3 commits into from Jul 30, 2019

Conversation

native-api added 3 commits Jul 26, 2019
Copy link
Member

pfmoore left a comment

I'd like to know what other @pypa/pip-committers think. Does anyone think the proposed wording is too strong? I'm happy with it, myself.

Copy link
Member

pradyunsg left a comment

I'm ambivalent on the wording -- it works for me but I don't really feel strongly either way.

@pradyunsg

This comment has been minimized.

Copy link
Member

pradyunsg commented Jul 30, 2019

Merging since... well... it works well enough?

@pradyunsg pradyunsg merged commit dc7f2b9 into pypa:master Jul 30, 2019
25 checks passed
25 checks passed
Linux Build #20190726.8 succeeded
Details
Linux (Package) Package succeeded
Details
Linux (Test Primary Python27) Test Primary Python27 succeeded
Details
Linux (Test Primary Python36) Test Primary Python36 succeeded
Details
Linux (Test Secondary Python35) Test Secondary Python35 succeeded
Details
Linux (Test Secondary Python37) Test Secondary Python37 succeeded
Details
Windows Build #20190726.8 succeeded
Details
Windows (Package) Package succeeded
Details
Windows (Test Primary Python27-x64) Test Primary Python27-x64 succeeded
Details
Windows (Test Primary Python36-x64) Test Primary Python36-x64 succeeded
Details
Windows (Test Secondary Python27-x86) Test Secondary Python27-x86 succeeded
Details
Windows (Test Secondary Python35-x64) Test Secondary Python35-x64 succeeded
Details
Windows (Test Secondary Python35-x86) Test Secondary Python35-x86 succeeded
Details
Windows (Test Secondary Python36-x86) Test Secondary Python36-x86 succeeded
Details
Windows (Test Secondary Python37-x64) Test Secondary Python37-x64 succeeded
Details
Windows (Test Secondary Python37-x86) Test Secondary Python37-x86 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
macOS Build #20190726.8 succeeded
Details
macOS (Package) Package succeeded
Details
macOS (Test Primary Python27) Test Primary Python27 succeeded
Details
macOS (Test Primary Python36) Test Primary Python36 succeeded
Details
macOS (Test Secondary Python35) Test Secondary Python35 succeeded
Details
macOS (Test Secondary Python37) Test Secondary Python37 succeeded
Details
news-file/pr News files updated and/or change is trivial.
Details
@pradyunsg

This comment has been minimized.

Copy link
Member

pradyunsg commented Jul 30, 2019

Thanks @native-api for the PR! :D

@native-api native-api deleted the native-api:ignore_install_considered_harmful branch Jul 30, 2019
@lock lock bot added the S: auto-locked label Aug 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.